dspdfviewer: vendor poppler

[commitay]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Alternative options:

1. Make qt required for poppler
2. Make a keg only poppler-qt formula?
3. Vendor poppler with qt?

install events in the last 365 days
================================================================================
1 | dspdfviewer                                                  | 643 |  99.54%
2 | dspdfviewer --HEAD                                           |   3 |   0.46%
================================================================================
Total                                                            | 646 |    100%
================================================================================

install events in the last 365 days
================================================================================
 1 | poppler                                                 | 193,263 |  97.67%
 2 | poppler --with-qt                                       |   3,814 |   1.93%

[fxcoudert]

We can vendor poppler this way:

diff --git a/Formula/dspdfviewer.rb b/Formula/dspdfviewer.rb
index 5e53f7c500..14139acb84 100644
--- a/Formula/dspdfviewer.rb
+++ b/Formula/dspdfviewer.rb
@@ -3,7 +3,7 @@ class Dspdfviewer < Formula
   homepage "https://dspdfviewer.danny-edel.de/"
   url "https://github.com/dannyedel/dspdfviewer/archive/v1.15.1.tar.gz"
   sha256 "c5b6f8c93d732e65a27810286d49a4b1c6f777d725e26a207b14f6b792307b03"
-  revision 6
+  revision 7
 
   head "https://github.com/dannyedel/dspdfviewer.git"
 
@@ -15,20 +15,76 @@ class Dspdfviewer < Formula
   end
 
   depends_on "cmake" => :build
+  depends_on "gobject-introspection" => :build
   depends_on "pkg-config" => :build
   depends_on "boost"
-  depends_on "poppler" => "with-qt"
+  depends_on "cairo"
+  depends_on "fontconfig"
+  depends_on "freetype"
+  depends_on "gettext"
+  depends_on "glib"
+  depends_on "jpeg"
+  depends_on "libpng"
+  depends_on "libtiff"
+  depends_on "openjpeg"
   depends_on "qt"
 
+  needs :cxx11
+
+  resource "poppler" do
+    url "https://poppler.freedesktop.org/poppler-0.65.0.tar.xz"
+    sha256 "89c8cf73f83efda78c5a9bd37c28f4593ad0e8a51556dbe39ed81e1ae2dd8f07"
+  end
+
+  resource "font-data" do
+    url "https://poppler.freedesktop.org/poppler-data-0.4.9.tar.gz"
+    sha256 "1f9c7e7de9ecd0db6ab287349e31bf815ca108a5a175cf906a90163bdbe32012"
+  end
+
   def install
-    args = std_cmake_args
-    args << "-DUsePrerenderedPDF=ON"
-    args << "-DRunDualScreenTests=OFF"
-    args << "-DUseQtFive=ON"
+    ENV.cxx11
+
+    resource("poppler").stage do
+      system "cmake", ".", *std_cmake_args,
+                           "-DCMAKE_INSTALL_PREFIX=#{libexec}",
+                           "-DBUILD_GTK_TESTS=OFF",
+                           "-DENABLE_CMS=none",
+                           "-DENABLE_GLIB=ON",
+                           "-DENABLE_QT5=ON",
+                           "-DWITH_GObjectIntrospection=ON",
+                           "-DENABLE_XPDF_HEADERS=ON"
+      system "make", "install"
+
+      libpoppler = (libexec/"lib/libpoppler.dylib").readlink
+      to_fix = ["#{libexec}/lib/libpoppler-cpp.dylib", "#{libexec}/lib/libpoppler-glib.dylib",
+                "#{libexec}/lib/libpoppler-qt5.dylib", *Dir["#{libexec}/bin/*"]]
+      
+      to_fix.each do |f|
+        macho = MachO.open(f)
+        macho.change_dylib("@rpath/#{libpoppler}", "#{libexec}/lib/#{libpoppler}")
+        macho.write!
+      end
+
+      resource("font-data").stage do
+        system "make", "install", "prefix=#{libexec}"
+      end
+    end
+
+    ENV.prepend_path "PKG_CONFIG_PATH", "#{libexec}/lib/pkgconfig"
+    ENV.prepend "LDFLAGS", "-L#{libexec}/lib"
+
     mkdir "build" do
-      system "cmake", "..", *args
+      system "cmake", "..", *std_cmake_args,
+                            "-DRunDualScreenTests=OFF",
+                            "-DUsePrerenderedPDF=ON",
+                            "-DUseQtFive=ON"
       system "make", "install"
     end
+
+    libpoppler = (libexec/"lib/libpoppler-qt5.dylib").readlink
+    macho = MachO.open(bin/"dspdfviewer")
+    macho.change_dylib("@rpath/#{libpoppler}", "#{libexec}/lib/#{libpoppler}")
+    macho.write!
   end
 
   test do

[commitay]

PR updated, thanks @fxcoudert!