git: add option to enable i18n support

[moonfruit]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

Fix for #31980

[fxcoudert]

I'd rather make it non-optional (i.e. mandatory) so all users can benefit from it.

[lembacon]

👍 on making gettext a mandatory dependency.

[MikeMcQuaid]

I would also support making gettext (and maybe even pcre2) mandatory

[sjackman]

Fun chicken and egg problem on El Capitan. Host's git is too old, so it tries to install git by downloading the bottle, which doesn't exist, because it hasn't been created yet by this PR.
https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/30354/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/install/

[dconnolly]

gettext requires javac, which is a blocker on some systems, and wasn't a blocker to installing git before.

[golovnin]

I think this change was not fully tested. I use on my Mac multiple languages: English, German, Russian and Greek. The value of LC_CTYPE is en_US.UTF-8. Before this change all messages of GIT were in English. After this change GIT uses now Russian. It is not a big problem for me because I understand Russian. But it is not the right behaviour:
user:~ $ echo $LC_CTYPE
en_US.UTF-8
user:~ $ git --help
использование: git [--version] [--help] [-C <путь>] [-c <имя>=<значение>]
[--exec-path[=<путь>]] [--html-path] [--man-path] [--info-path]
[-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
[--git-dir=<путь>] [--work-tree=<путь>] [--namespace=<имя>]
<команда> [<аргументы>]

Стандартные команды Git используемые в различных ситуациях:

[sjackman]

Please report the output of locale and

LANG=en_US.UTF-8 git --version
LANG=ru_RU.UTF-8 git --version

[fxcoudert]

@dconnolly gettext does not require javac. Java is disabled in Homebrew's gettext. If there is a specific issue, please open a ticket and we will look at it.

[golovnin]

user:~ $ locale
LANG=
LC_COLLATE="C"
LC_CTYPE="en_US.UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

user:~ $ LANG=en_US.UTF-8 git --version
git version 2.19.0
user:~ $ LANG=ru_RU.UTF-8 git --version
git version 2.19.0

user:~ $ LANG=en_US.UTF-8 git --help
usage: git [--version] [--help] [-C ] [-c =]
[--exec-path[=]] [--html-path] [--man-path] [--info-path]
[-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
[--git-dir=] [--work-tree=] [--namespace=]
[]

user:~ $ LANG=ru_RU.UTF-8 git --help
использование: git [--version] [--help] [-C <путь>] [-c <имя>=<значение>]
[--exec-path[=<путь>]] [--html-path] [--man-path] [--info-path]
[-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
[--git-dir=<путь>] [--work-tree=<путь>] [--namespace=<имя>]
<команда> [<аргументы>]

[sjackman]

Cool. Looks like it's working as expected. Use LANG to switch languages.

[golovnin]

Cool. Looks like it's working as expected.

Not from my point of view. I would expect that the primary language is used, as it is configured in the Mac OS preferences. I my case English is the primary language and Russian is the second language. But I think it is acceptable to set an environment variable. Thanks a lot!

[mreinsch]

@sjackman I'm experiencing similar issue. I'm using Mac set to English with German as second locale in Germany. After updating to this version of git, all messages are suddenly in German, while everything else is (as it should be) in English.

Also I'm at a loss from where git is taking the locale information. local for me also gives:

LANG=
LC_COLLATE="C"
LC_CTYPE="UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

So why does git use German?! Again, no other tool is using German locale.

[sjackman]

I really can't say where it's getting the language configuration from. You can add to the file ~/.profile (or ~/.bash_profile if it already exists) the following:

export LANG=en_US.UTF-8

[darwin]

Same problem here. Git (2.19.0_1) unexpectedly started talking to me in Spanish. brew switch git 2.19.0 fixed the issue.

In System Preferences > Language & Region I have "Preferred languages" in this order:

1. English - Primary
2. Czech
3. Spanish

> sw_vers
ProductName:	Mac OS X
ProductVersion:	10.13.6
BuildVersion:	17G65

> locale
LANG=
LC_COLLATE="C"
LC_CTYPE="UTF-8"
LC_MESSAGES="C"
LC_MONETARY="C"
LC_NUMERIC="C"
LC_TIME="C"
LC_ALL=

[sjackman]

Rather than switching to an older version of git, I'd suggested adding to your ~/.profile (or ~/.bash_profile if it already exists) the following:

export LANG=en_US.UTF-8

[darwin]

Thanks for the suggestion. I understand that specifying LANG explicitly would solve the issue. But I'm not going to do that because AFAIK it is not standard setting on pristine macOS machine and this could interfere with other commands I would run.

To me it looks like an issue with git itself or somewhere someone wrongly interprets preferred languages list in preferences and taking the last option, instead of primary one.

[sjackman]

Possibly it's a bug in either git or gettext or macOS. It's certainly odd. My current best guess would be possibly a bug in gettext.

[darwin]

Sure. No worries. I can workaround it by setting a git alias which sets LANG for each git invocation. At least temporarily until this gets fixed. I'm afraid I'm not the last person who will complain here.

[inosik]

I must admit I find this pretty annoying. I switch all my development tools to English, because the German translations tend to be rather horrible. And, you have a much harder time searching for error messages if they're translated.