Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpgme: package python3 bindings as well - require python3 for build #33129

Closed
wants to merge 3 commits into from

Conversation

michael-paddle
Copy link
Contributor

@michael-paddle michael-paddle commented Oct 18, 2018

Currently gpgme doesn't package the python3 bindings, only the python2.7 ones. By adding a build dependency to python (== python 3) we ensure that the python3 bindings are also built and packaged.


  • [/] Have you followed the guidelines for contributing?
  • [/] Have you checked that there aren't other open pull requests for the same formula update/change?
  • [/] Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • [/] Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

A note on this PR; during testing I discovered that if you have standard python.org python installed then it does't find the bindings. I wonder if there is anything that could be easily done to make homebrew bindings automatically visible to python.org python. The debian solution is to have a dist-packages directory which is supposed to be visible in all python versions but come after the site-packages allowing packages there to be used but overridden as needed.

@fxcoudert
Copy link
Member

When building Python bindings, we usually make the python requirement for runtime too… after all, the bindings are otherwise useless.

@fxcoudert fxcoudert added the maintainer feedback Additional maintainers' opinions may be needed label Oct 19, 2018
@michael-paddle
Copy link
Contributor Author

@fxcoudert ; I'd propose an exception in this case because the package is useful if you only want the C bindings but the other language bindings have already been included. If you want to use it with python then, obviously, you need to have python installed.

@stale
Copy link

stale bot commented Nov 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Nov 22, 2018
@michael-paddle
Copy link
Contributor Author

@Stale bot please don't mark this issue as stale; It's waiting for @fxcoudert to have time to reply.

@stale stale bot removed the stale No recent activity label Nov 22, 2018
@stale
Copy link

stale bot commented Dec 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Dec 13, 2018
@SMillerDev SMillerDev added the in progress Stale bot should stay away label Dec 13, 2018
@stale stale bot removed the stale No recent activity label Dec 13, 2018
@fxcoudert fxcoudert added ready to merge PR can be merged once CI is green and removed in progress Stale bot should stay away maintainer feedback Additional maintainers' opinions may be needed labels Mar 4, 2019
@fxcoudert
Copy link
Member

fxcoudert commented Mar 4, 2019

Oops. Completely forgot about that one. I suppose it's okay-ish.

@fxcoudert
Copy link
Member

@BrewTestBot test this please

@fxcoudert fxcoudert closed this in 0736053 Mar 4, 2019
@lock lock bot added the outdated PR was locked due to age label Apr 3, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants