Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] 0.18.7 (new formula) #40926

Closed
wants to merge 1 commit into from
Closed

[email protected] 0.18.7 (new formula) #40926

wants to merge 1 commit into from

Conversation

cscheib
Copy link

@cscheib cscheib commented Jun 12, 2019

creates a new versioned formula for terraform 0.18, since there are breaking syntax changes in 0.19

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot
Copy link
Member

  • New formulae should not have a bottle do block

@SMillerDev
Copy link
Member

Is 0.18 actively supported by upstream?

created from previous unversioned formula
modify to use versioned terraform dependency
@cscheib
Copy link
Author

cscheib commented Jun 12, 2019

Is 0.18 actively supported by upstream?

@SMillerDev
That's mildly unclear, but I suspect yes. Terragrunt 0.18 works with Terraform 0.11, whereas 0.19 works with Terraform 0.12. Terraform 0.11 will likely be supported by Hashi for some time, due to the syntax changes in HCL, so Terragrunt will need to linger at 0.18 for some time along with.

A release to 0.18 was done 8 days ago:
https://github.com/gruntwork-io/terragrunt/releases

@fxcoudert fxcoudert added legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core labels Jun 12, 2019
@chenrui333
Copy link
Member

Yeah, I think terragrunt team needs to support it :)

As we have [email protected], this formula is very much aligned with it. People has to deal with the migration pain for the existing infrastructure pieces.

@cscheib
Copy link
Author

cscheib commented Jun 14, 2019

any more thoughts on this? I'm hosting a formula in my own tap repo, explicitly just for this, but I'd honestly like to see it in the main repo, so others can benefit.

It makes sense to keep [email protected] around as long as [email protected] is around. Seeing as terragrunt is a wrapper around Terraform, there really would only be so many changes/updates to this software ongoing anyway, as Terraform 0.11 isn't likely to see much more change.

There are few people who are going to wholesale upgrade to Terraform 0.12 immediately

@cscheib
Copy link
Author

cscheib commented Jun 14, 2019

also, normally, I'd just run from an old version of the package via URL, and pin... but, that was made impractical since the un-versioned terraform package went to 0.12, making the dependency the original 0.18 formula had on vanilla terraform not useful.

@fxcoudert
Copy link
Member

Looking at the history of terragrunt releases, it appears they don't maintain older branches. There have been no point releases to older branches in the past years.

Per https://docs.brew.sh/Versions, unless there is a statement to the contrary by upstream, we should not merge this.

@SMillerDev
Copy link
Member

Per https://docs.brew.sh/Versions, unless there is a statement to the contrary by upstream, we should not merge this.

No support means no homebrew-core formula unfortunately, I think people would be grateful if you make a tap for this though.

@SMillerDev SMillerDev closed this Jun 25, 2019
@chenrui333 chenrui333 mentioned this pull request Aug 15, 2019
5 tasks
@lock lock bot added the outdated PR was locked due to age label Jan 30, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants