Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify-cli 2.11.23 (new formula) #41453

Closed
wants to merge 1 commit into from
Closed

Conversation

cglong
Copy link
Contributor

@cglong cglong commented Jun 29, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 29, 2019
@SMillerDev SMillerDev added the ready to merge PR can be merged once CI is green label Jul 1, 2019
@fxcoudert fxcoudert closed this in ee1c716 Jul 2, 2019
@cglong cglong deleted the netlify-cli branch July 2, 2019 19:18
class NetlifyCli < Formula
desc "Netlify command-line tool"
homepage "https://www.netlify.com/docs/cli"
url "https://registry.npmjs.org/netlify-cli/-/netlify-cli-2.11.23.tgz"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cglong any way to make this dynamic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no; Homebrew requires that formulae be versioned and reproducible. This shouldn't be a problem practically though, as PRs to bump the versions typically get opened within a day or two 🙂

@lock lock bot added the outdated PR was locked due to age label Jan 26, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants