Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breezy 3.0.2 #46941

Closed
wants to merge 1 commit into from
Closed

breezy 3.0.2 #46941

wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Nov 19, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Will hopefully help in getting one step closer towards Python 3.8 (#45337).

@bayandin
Copy link
Member

bayandin commented Nov 19, 2019 •
edited
Loading

@Bo98 I think we could switch resource "Cython" to depends_on "cython" => :build since it's not required in runtime

@Bo98
Copy link
Member Author

Bo98 commented Nov 19, 2019

@bayandin Sounds good to me - done now.

wxPython will follow shortly. Just trying a build locally just now.

@bayandin bayandin mentioned this pull request Nov 20, 2019
Closed
10 tasks
chenrui333
chenrui333 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Bo98 Bo98 closed this in 8e25e02 Nov 20, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @bayandin @chenrui333