Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 13.2.0 #47042

Closed
wants to merge 1 commit into from
Closed

node 13.2.0 #47042

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@billinghamj
Copy link
Contributor

@chenrui333 Could you please remove these lines: https://github.com/Homebrew/homebrew-core/pull/47042/files#diff-d3ef2414308e30df24a517ca9a1324eeL25-L30

diogoazevedos
diogoazevedos suggested changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@diogoazevedos diogoazevedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update npm to 6.13.1?

@chenrui333
Copy link
Member Author

@chenrui333 Could you please remove these lines: https://github.com/Homebrew/homebrew-core/pull/47042/files#diff-d3ef2414308e30df24a517ca9a1324eeL25-L30

how is that related to this python3 tracker, nodejs/node#25789

@billinghamj
Copy link
Contributor

Maybe it'll need a different patch or something.

@chenrui333
Copy link
Member Author

Relates to my ungit PR, #47057

@chenrui333
Copy link
Member Author

ungit test step only failed on Mojave build though

12:21:21 ==> brew test --verbose ungit
12:21:24 ==> FAILED
12:21:24 Testing ungit
12:21:24 /usr/bin/sandbox-exec -f /private/tmp/homebrew20191122-43085-w1oo9s.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/ungit.rb --verbose
12:21:24 Error: ungit: failed

@chrmoritz
Copy link
Contributor

chrmoritz commented Nov 22, 2019 •
edited
Loading

@chenrui333 The Python 3 patch is no longer needed because it's part of node 13.2.0 (that's what I've meant with 'remove with next version').

@chrmoritz chrmoritz mentioned this pull request Nov 23, 2019
Closed
62 tasks
@Bo98
Copy link
Member

Bo98 commented Nov 24, 2019

@BrewTestBot test this please

@chenrui333
Copy link
Member Author

Thanks all for the participations and help!!

@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
@chenrui333 chenrui333 deleted the node-13.2.0 branch December 18, 2022 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diogoazevedos diogoazevedos diogoazevedos approved these changes

@billinghamj billinghamj billinghamj approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chenrui333 @billinghamj @chrmoritz @Bo98 @diogoazevedos