aws-elasticbeanstalk 3.16.0 #47488
Closed
aws-elasticbeanstalk 3.16.0 #47488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 ❌ |
|
The file on line 161 doesn't seem to exist anymore according to jenkins |
|
I checked all the releases since 3.14.6 for that file: It was removed in 3.14.9, with no notes in the changelog as to why. Maybe they forgot about it, or maybe it legitimately didn't work any more? If this were a project with a GitHub repo I'd raise an issue and ask, but alas it is not. I guess I'll remove the completions. |
|
I think you need to update the resources too. It's missing something. |
- Update a load of resources too.
issyl0
force-pushed
the
aws-elasticbeanstalk-3.16.0
branch
from
74f2f95
to
7007314
Compare
- The `bin/eb_completion.bash` file was removed from the source in v3.14.9 with no explanation as to why.
|
I updated many resources. The test passes locally now. 🤞 for CI. |
issyl0
added
ready to merge
chenrui333
approved these changes
Dec 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.Resolves some conversation about revision bumps after #47369.