Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwntools: use system python 2 #47873

Closed
wants to merge 1 commit into from
Closed

pwntools: use system python 2 #47873

wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Dec 14, 2019

Because we will remove the python@2 formula end of 2019.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@iMichka iMichka added the python Python use is a significant feature of the PR or issue label Dec 14, 2019
@iMichka iMichka self-assigned this Dec 14, 2019
@fxcoudert fxcoudert mentioned this pull request Dec 14, 2019
Closed
62 tasks
@iMichka
pwntools: use system python 2
4d13836 
Because we will remove the python@2 formula end of 2019.
@Moisan
Copy link
Member

Moisan commented Dec 30, 2019

This PR works fine locally on Mojave for me. Re-launching the CI to see the error.
@BrewTestBot test this please.

@iMichka
Copy link
Member Author

iMichka commented Dec 30, 2019

Yes. This has been fixed by: Homebrew/brew#6878
:)

@iMichka iMichka closed this in 15c7146 Dec 30, 2019
@iMichka iMichka deleted the pwntools branch December 30, 2019 22:29
@lock lock bot added the outdated PR was locked due to age label Jan 30, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@iMichka iMichka

Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMichka @Moisan