rocksdb 4.5.1

[Jerzerak]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
• Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
• Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

Description

Bump rocksdb stable version from 4.4.1 to 4.5.1

[apjanke]

Test failure:

    Test Result (3 failures / +3)

    brew-test-bot.el_capitan.linkage --test osquery
    brew-test-bot.mavericks.linkage --test osquery
    brew-test-bot.yosemite.linkage --test osquery

failed: brew linkage --test osquery

Stacktrace

        Missing libraries:
  /usr/local/opt/rocksdb/lib/librocksdb.4.4.dylib

This means that osquery needs to have its revision bumped so it picks up the new rocksdb dylib version. You can add it to this PR in another commit.

Looks like this breakage actually happened in the previous rocksdb version bump; it's just being caught now because the linkage --test check was recently introduced.

[Jerzerak]

@apjanke let me know if anything else needs doing

[dunn]

The bottle revision is different from the formula revision; the latter goes outside the bottle block just below the sha256. But it seems like it's not necessary here since the build is passing as-is.

[apjanke]

You're good to go.

Merged. Thank you for your contribution to Homebrew!

For future reference, normally we bump the revision of the formula itself, not the bottle revision. Unlikely to matter here since osquery has no options. We're talking about clearing this terminology up: Homebrew/brew#38.

[Jerzerak]

@apjanke Thanks! The documentation was a little confusing on that part so I went with what I thought would work based on some old PR's with revision bumps.