Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 1.7.4 #71050

Closed
wants to merge 1 commit into from
Closed

deno 1.7.4 #71050

wants to merge 1 commit into from

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Feb 13, 2021

action-homebrew-bump-formula


Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Feb 13, 2021
@carlocab
Copy link
Member

Commit Big Sur ARM Big Sur Catalina Mojave CI Logs
1cd0d1c1ce0bcc17436e5f7104df984214e72de9 https://github.com/Homebrew/homebrew-core/actions/runs/564044255

@carlocab
Copy link
Member

Errors are the same across the four nodes, so I think there's something wrong that needs fixing:

[rusty_v8 0.17.0] ninja: error: '../../../../../../../Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/github.com-1ecc6299db9ec823/rusty_v8-0.17.0/v8/tools/gen-v8-gn.py', needed by 'gen/v8/include/v8-gn.h', missing and no known rule to make it

@Bo98
Copy link
Member

Bo98 commented Feb 13, 2021

Deno 1.7.3 (and 1.7.4) ships with a buggy rusty_v8 0.17.0, that simply doesn't build from source from its cargo crate. The bug was fixed in rusty_v8 0.18.1. There's an effort to update to the latest rusty_v8 here: denoland/deno#9466

Until then, this is probably a "won't merge" unless someone knows a temporary workaround.

@Bo98
Copy link
Member

Bo98 commented Feb 13, 2021

(Also, Deno gets a new version weekly so it won't be long before the next version is out and any effort to workaround bugs is pointless)

@chenrui333
Copy link
Member Author

Sounds good, closing the PR and wait for the next release.

@chenrui333 chenrui333 closed this Feb 15, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 18, 2021
@chenrui333 chenrui333 deleted the bump-deno-1.7.4 branch December 18, 2022 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants