Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: workaround flaky crates.io downloads #83977

Closed
wants to merge 1 commit into from

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Aug 25, 2021

See
rust-lang/cargo#9695

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. labels Aug 25, 2021
@BrewTestBot BrewTestBot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Aug 25, 2021
Formula/rust.rb Outdated Show resolved Hide resolved
@dawidd6
Copy link
Member

dawidd6 commented Aug 26, 2021

Looks like skipping dependents testing didn't work out

@iMichka
Copy link
Member Author

iMichka commented Aug 26, 2021

Looks like skipping dependents testing didn't work out

I think it worked on Linux but not on ARM, cc @MikeMcQuaid

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Formula/rust.rb Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

@iMichka @dawidd6 gonna need more than "didn't work" I'm afraid 😅. Also would be good to figure out whether it's dependents or recursive dependents or both that doesn't work.

@iMichka
Copy link
Member Author

iMichka commented Aug 26, 2021

What we expected is that only the bottle to be built, and no other tests to be run, to have a quick build.

Actually I am correcting what I said above, some tests where still run on Linux, but way less.

Look for Testable dependents in the logs: we expect this list to be empty, given the 2 labels we used (CI-skip-dependents and CI-Skip-recursive-dependents).

Maybe this is due to a weird interaction with the CI-build-dependents-from-source label?

@MikeMcQuaid
Copy link
Member

@iMichka I think #84024 will fix this. Could cherry-pick that commit into this PR for testing (if desired) before merging?

@iMichka iMichka requested a review from dawidd6 as a code owner August 26, 2021 12:59
@BrewTestBot BrewTestBot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 26, 2021
@iMichka
Copy link
Member Author

iMichka commented Aug 26, 2021

Running again with your fix to test the CI labels.

@MikeMcQuaid
Copy link
Member

Running again with your fix to test the CI labels.

Looks from the ARM build like it is being skipped as expected.

@dawidd6
Copy link
Member

dawidd6 commented Aug 26, 2021

Now why is linux builld taking so long

@dawidd6
Copy link
Member

dawidd6 commented Aug 26, 2021

It hanged on brew install rust

@Bo98
Copy link
Member

Bo98 commented Aug 26, 2021

Doesn't really say much. It takes 3 hours to build Rust on macOS Intel, and Linux CI has been at least 2x slower when I've been doing Swift builds.

@Bo98
Copy link
Member

Bo98 commented Aug 26, 2021

Earlier build took a little over 4 hours on Linux so it was probably cancelled when it was near finished to be honest.

@dawidd6
Copy link
Member

dawidd6 commented Aug 26, 2021

Let's rerun then. Looked weird for me that it was building that long, but if you say so then okay.

@cho-m
Copy link
Member

cho-m commented Aug 26, 2021

ARM build randomly failed this time.

Also, commit history looks a bit off as it includes an already-merged commit. Can we rebase it?

@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Aug 27, 2021
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@iMichka iMichka deleted the rust branch August 27, 2021 14:25
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants