-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: workaround flaky crates.io downloads #83977
Conversation
Looks like skipping dependents testing didn't work out |
I think it worked on Linux but not on ARM, cc @MikeMcQuaid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
What we expected is that only the bottle to be built, and no other tests to be run, to have a quick build. Actually I am correcting what I said above, some tests where still run on Linux, but way less. Look for Maybe this is due to a weird interaction with the CI-build-dependents-from-source label? |
Running again with your fix to test the CI labels. |
Looks from the ARM build like it is being skipped as expected. |
Now why is linux builld taking so long |
It hanged on brew install rust |
Doesn't really say much. It takes 3 hours to build Rust on macOS Intel, and Linux CI has been at least 2x slower when I've been doing Swift builds. |
Earlier build took a little over 4 hours on Linux so it was probably cancelled when it was near finished to be honest. |
Let's rerun then. Looked weird for me that it was building that long, but if you say so then okay. |
ARM build randomly failed this time. Also, commit history looks a bit off as it includes an already-merged commit. Can we rebase it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
See
rust-lang/cargo#9695
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?