-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sysdig: build on Linux #87581
sysdig: build on Linux #87581
Conversation
9879026
to
1671766
Compare
We need the patch adopted by Arch Linux and reported upstream at draios/sysdig#1778 to build this on Linux.
1671766
to
4b120e6
Compare
Ok, I think I've tried all the suggestions from #84990 and then some. @danielnachun @cho-m any ideas here? |
Current error is happening in Protobuf-generated C header, but I am not sure of exact reason:
It might be the same problem Arch hit when trying to use C++17 standard, which is mentioned in the same upstream issue:
Can try dropping C++17 changes and see if it works even though there is different C++ standard between |
-DCMAKE_CXX_STANDARD=17 | ||
] | ||
end | ||
# We need C++17 to use Abseil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# We need C++17 to use Abseil. |
Oops. I'll remove this when merging...
I forgot to remove this in Homebrew#87581.
I forgot to remove this in #87581. Closes #87701. Signed-off-by: Sean Molenaar <[email protected]> Signed-off-by: BrewTestBot <[email protected]>
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Let's see if this builds with minimal workarounds first.