Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysdig: build on Linux #87581

Merged
merged 3 commits into from
Oct 21, 2021
Merged

sysdig: build on Linux #87581

merged 3 commits into from
Oct 21, 2021

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Let's see if this builds with minimal workarounds first.

@carlocab carlocab added do not merge CI-test-bot-fail-fast Pass --fail-fast to brew test-bot. CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. CI-no-bottles Merge without publishing bottles labels Oct 19, 2021
@BrewTestBot BrewTestBot added lua Lua use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle labels Oct 19, 2021
We need the patch adopted by Arch Linux and reported upstream at
draios/sysdig#1778 to build this on Linux.
@carlocab
Copy link
Member Author

Ok, I think I've tried all the suggestions from #84990 and then some. @danielnachun @cho-m any ideas here?

@cho-m
Copy link
Member

cho-m commented Oct 21, 2021

Current error is happening in Protobuf-generated C header, but I am not sure of exact reason:

/tmp/sysdig-20211019-18237-b1mrls/sysdig-0.27.1/build/userspace/libsinsp/cri.pb.h:2883:53: error: expected unqualified-id before numeric constant
 2883 |   const ::runtime::v1alpha2::LinuxPodSandboxConfig& linux() const;
      |                                                     ^~~~~

It might be the same problem Arch hit when trying to use C++17 standard, which is mentioned in the same upstream issue:

I tried building sysdig with c++17 as well, patching the cmake files where necessary, but it fails with a different type of error with the code generated by protobuf, I think. I don't have the log handy at the moment, but I can try it again and paste it here later if you need it.

Can try dropping C++17 changes and see if it works even though there is different C++ standard between abseil and sysdig.

@carlocab carlocab added ready to merge PR can be merged once CI is green and removed do not merge labels Oct 21, 2021
-DCMAKE_CXX_STANDARD=17
]
end
# We need C++17 to use Abseil.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# We need C++17 to use Abseil.

Oops. I'll remove this when merging...

@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Oct 21, 2021
@carlocab carlocab merged commit 03b9d5a into Homebrew:master Oct 21, 2021
@carlocab carlocab deleted the sysdig-linux branch October 21, 2021 12:57
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Oct 21, 2021
@carlocab carlocab mentioned this pull request Oct 21, 2021
6 tasks
BrewTestBot pushed a commit that referenced this pull request Oct 21, 2021
I forgot to remove this in #87581.

Closes #87701.

Signed-off-by: Sean Molenaar <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-force-linux [DEPRECATED] Don't pass --skip-unbottled-linux to brew test-bot. CI-no-bottles Merge without publishing bottles CI-test-bot-fail-fast Pass --fail-fast to brew test-bot. lua Lua use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants