node 17.1.0

[tuzi3040]

Created with brew bump-formula-pr.

resource blocks may require updates.

npm updated to 8.1.2.

[carlocab]

Probably needs OpenSSL 3.0. We'd need to make [email protected] a build dependency (and probably make it [email protected] while we're at it), and add jupyterlab, anime-downloader and emscripten to the versioned conflicts allowlist.

lanraragi will also be a problem.

[carlocab]

I think this will fail the tap syntax job for conflicting versioned dependencies.

[tuzi3040]

Also, in the previous check, clang raised error since SSL_QUIC_METHOD is not found.

  clang -o /private/tmp/node-20211109-60450-k5ll9i/node-v17.1.0/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o ../deps/openssl/openssl/ssl/bio_ssl.c '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CERT_STORE' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_NO_HW' '-DOPENSSL_API_COMPAT=0x10100001L' '-DSTATIC_LEGACY' '-DNDEBUG' '-DL_ENDIAN' '-DOPENSSL_BUILDING_OPENSSL' '-DECP_NISTZ256_ASM' '-DKECCAK1600_ASM' '-DOPENSSL_BN_ASM_MONT' '-DOPENSSL_CPUID_OBJ' '-DPOLY1305_ASM' '-DSHA1_ASM' '-DSHA256_ASM' '-DSHA512_ASM' '-DVPAES_ASM' '-DOPENSSL_PIC' '-DENGINESDIR="/dev/null"' -I/opt/homebrew/opt/libuv/include -I/opt/homebrew/opt/brotli/include -I/opt/homebrew/opt/c-ares/include -I/opt/homebrew/opt/libnghttp2/include -I/opt/homebrew/opt/openssl@3/include -I/opt/homebrew/Cellar/icu4c/69.1/include -I../deps/openssl/openssl -I../deps/openssl/openssl/include -I../deps/openssl/openssl/crypto -I../deps/openssl/openssl/crypto/include -I../deps/openssl/openssl/crypto/modes -I../deps/openssl/openssl/crypto/ec/curve448 -I../deps/openssl/openssl/crypto/ec/curve448/arch_32 -I../deps/openssl/openssl/providers/common/include -I../deps/openssl/openssl/providers/implementations/include -I../deps/openssl/config -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2 -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/include -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/crypto/include/internal -I../deps/openssl/config/archs/darwin64-arm64-cc/asm_avx2/providers/common/include  -O3 -gdwarf-2 -flto -mmacosx-version-min=10.13 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -Wno-missing-field-initializers -fno-strict-aliasing -MMD -MF /private/tmp/node-20211109-60450-k5ll9i/node-v17.1.0/out/Release/.deps//private/tmp/node-20211109-60450-k5ll9i/node-v17.1.0/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o.d.raw   -c

In file included from ../deps/openssl/openssl/ssl/bio_ssl.c:17:
../deps/openssl/openssl/ssl/ssl_local.h:1213:11: error: unknown type name 'SSL_QUIC_METHOD'; did you mean 'SSL_METHOD'?
    const SSL_QUIC_METHOD *quic_method;
          ^~~~~~~~~~~~~~~
          SSL_METHOD
/opt/homebrew/opt/openssl@3/include/openssl/ssl.h:229:30: note: 'SSL_METHOD' declared here
typedef struct ssl_method_st SSL_METHOD;
                             ^

This is because QUIC is not yet implemented in official release of OpenSSL 3.
node used quictls/openssl to support QUIC in node@17.
nodejs/node#38512
node@17 release note

We might need to switch to quictls to build.

[carlocab]

Do we not just need to pass --openssl-legacy-provider?

You'll also need to squash your commits together, because @BrewTestBot can't do that for you here (hence the automerge-skip label).

[tuzi3040]

Do we not just need to pass --openssl-legacy-provider?

Honestly, I don't think this would work, since this option is aimed at bypassing default restriction in OpenSSL 3.0. This probably has nothing to do with the QUIC stuff.

You'll also need to squash your commits together, because @BrewTestBot can't do that for you here (hence the automerge-skip label).

Got you, will do when ready to merge.

[carlocab]

Honestly, I don't think this would work, since this option is aimed at bypassing default restriction in OpenSSL 3.0. This probably has nothing to do with the QUIC stuff.

We should ask upstream if they no longer support building with a non-forked OpenSSL then.

Got you, will do when ready to merge.

Waiting until then will mean re-running CI another time, so sooner is probably better.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

[tuzi3040]

Also, in the previous check, clang raised error since SSL_QUIC_METHOD is not found.
We might need to switch to quictls to build.

Seems related to nodejs/node#40783.

We should ask upstream if they no longer support building with a non-forked OpenSSL then.

According to nodejs/node#38512, specifically the pr description,

We will still be able to dynamically link to OpenSSL 1.1.1 and we have a CI job which dynamically links to OpenSSL 1.1.1 which is run for every pull request to make sure that we maintain backward compatibility.

We probably don't need to use openssl@3 yet. Dynamic linked openssl 1.1 is still supported. Thus no dependence conflict.

[derrabus]

I think, we should leave this PR open until it's resolved, dear bot.

[tuzi3040]

I reverted two changes to switch back to openssl 1.1.1, would you please reopen this pr please? @carlocab

[carlocab]

Unfortunately, I can't reopen this either. The reopen button is greyed out with a comment that says "The bump-node-17.1.0 branch was force-pushed or recreated." when my mouse pointer hovers over it.

[tuzi3040]

Unfortunately, I can't reopen this either. The reopen button is greyed out with a comment that says "The bump-node-17.1.0 branch was force-pushed or recreated." when my mouse pointer hovers over it.

Oh, my bad. Opening another pr #89459.