Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 17.3.0 #91540

Closed
wants to merge 3 commits into from
Closed

node 17.3.0 #91540

wants to merge 3 commits into from

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Dec 18, 2021 •
edited
Loading

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Dec 18, 2021
@bevanjkay bevanjkay added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 18, 2021
chenrui333
chenrui333 previously approved these changes Dec 18, 2021
View reviewed changes
@chenrui333 chenrui333 mentioned this pull request Dec 18, 2021
Closed
@carlocab carlocab removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 19, 2021
@bevanjkay
Copy link
Member Author

@chenrui333 @carlocab
Tests are failing at the moment because of a symlink collision with corepack.
17.3.0 added a new --without-corepack build flag - nodejs/node@2125449f89
Could this help us here?

@SMillerDev
Copy link
Member

Yeah, that should probably be enabled

@branchvincent branchvincent added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 20, 2021
branchvincent
branchvincent approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linux timed out but no errors otherwise

@BrewTestBot
Copy link
Member

:shipit: @branchvincent has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2022
@SMillerDev SMillerDev removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@branchvincent branchvincent branchvincent approved these changes

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bevanjkay @SMillerDev @BrewTestBot @chenrui333 @branchvincent @carlocab