boringtun 0.4.0 #96335
Closed
boringtun 0.4.0 #96335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
BrewTestBot
added
no ARM bottle
carlocab
reviewed
Mar 7, 2022
Co-authored-by: Carlo Cabrera <[email protected]>
carlocab
reviewed
Mar 7, 2022
Signed-off-by: Rui Chen <[email protected]>
carlocab
approved these changes
Mar 7, 2022
carlocab
reviewed
Mar 7, 2022
Comment on lines
+37
to
+38
| # requires `sudo` to start | ||
| assert_match "BoringTun failed to start", output |
There was a problem hiding this comment.
The sudo requirement seems new. Is this documented upstream?
There was a problem hiding this comment.
I will check on this, the sudo issue got raised in this one
darthShadow
reviewed
Mar 7, 2022
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?raised the release tag missing issue in the upstream