-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet 6.0.104 #99175
dotnet 6.0.104 #99175
Conversation
|
GitHub runners don't have enough disk space (temp is about ~40-50GB at end of build). May be able to reduce requirement by trying |
Yeah my bad, didn't label this properly. But yes, we should definitely add that flag regardless. |
40610ba
to
8bdd261
Compare
8bdd261
to
9ba69b9
Compare
I'm guessing GNU vs BSD
|
9ba69b9
to
ca6956a
Compare
Added an |
GNU coreutils should support Alternative is the |
ca6956a
to
213b357
Compare
Error from trying to use system libunwind on macOS:
|
Odd since I assumed it was on by default on macOS: https://github.com/dotnet/runtime/blob/9c9ebb945eff9eb8fd02189ff93fb743235413c3/src/coreclr/pal/src/CMakeLists.txt#L3. |
Specifically, error is happening in https://github.com/dotnet/runtime/blob/v6.0.4/src/native/corehost/apphost/static/CMakeLists.txt#L214-L220 # On *BSD, we always use the libunwind that's part of the OS
if(CLR_CMAKE_TARGET_FREEBSD)
set(CLR_CMAKE_USE_SYSTEM_LIBUNWIND 1)
endif()
if(CLR_CMAKE_USE_SYSTEM_LIBUNWIND)
find_unwind_libs(UNWIND_LIBS) In other CMakeLists.txt, they avoid trying to find library on macOS https://github.com/dotnet/runtime/blob/v6.0.4/src/coreclr/pal/src/CMakeLists.txt#L19-L22 elseif(NOT CLR_CMAKE_TARGET_OSX)
find_unwind_libs(UNWIND_LIBS)
else()
add_subdirectory(libunwind) I guess there are issues with finding macOS libunwind.tbd |
213b357
to
36107f4
Compare
libunwind lies in the system dylib and so does not require linker flags, which is why there's a macOS conditional (the else condition was added at a later time for some DWARF handling - it initially just no-oped and it was able to use the system version without issue). I've pushed what I think the correct patch is - or it's at least consistent with how it worked in the past. |
Looks like we're now hitting dotnet/msbuild#7229. |
May want to add patch as resource and copy into https://github.com/dotnet/installer/tree/v6.0.104/src/SourceBuild/tarball/patches/msbuild |
36107f4
to
bbaa726
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
May need to figure out a livecheck
in separate PR as default git tags will end up picking 6.0.2XX.
Seems like it would be something like:
|
🤖 A scheduled task has triggered a merge. |
Created with
brew bump-formula-pr
.