Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet 6.0.104 #99175

Closed
wants to merge 1 commit into from
Closed

dotnet 6.0.104 #99175

wants to merge 1 commit into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 13, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Apr 13, 2022
@Bo98 Bo98 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 13, 2022
@EricFromCanada EricFromCanada added the CI-issue Failure due to temporary CI issue label Apr 13, 2022
@EricFromCanada
Copy link
Member

  Error: An exception occurred within a child process:
    Errno::ENOSPC: No space left on device @ fptr_finalize_flush - /github/home/.cache/Homebrew/Logs/dotnet/03.build.sh

@EricFromCanada EricFromCanada removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 13, 2022
@cho-m cho-m added the CI-linux-self-hosted Build on Linux self-hosted runner label Apr 13, 2022
@cho-m
Copy link
Member

cho-m commented Apr 13, 2022

GitHub runners don't have enough disk space (temp is about ~40-50GB at end of build).

May be able to reduce requirement by trying p:CleanWhileBuilding (dotnet/source-build#2782 (comment)).

@Bo98
Copy link
Member Author

Bo98 commented Apr 13, 2022

Yeah my bad, didn't label this properly.

But yes, we should definitely add that flag regardless.

@EricFromCanada EricFromCanada added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-issue Failure due to temporary CI issue CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Apr 13, 2022
@Bo98 Bo98 force-pushed the bump-dotnet-6.0.104 branch 2 times, most recently from 40610ba to 8bdd261 Compare April 14, 2022 18:58
@Bo98 Bo98 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 14, 2022
@cho-m
Copy link
Member

cho-m commented Apr 14, 2022

I'm guessing GNU vs BSD df. May need to report upstream and/or temporarily switch to coreutils:

DirSize Before Building source-build-reference-packages
    df --block-size=1M /private/tmp/d20220414-99118-19dsb29/
    df: illegal option -- -
    usage: df [-b | -H | -h | -k | -m | -g | -P] [-ailn] [-T type] [-t] [filesystem ...]
  /private/tmp/d20220414-99118-19dsb29/repos/Directory.Build.targets(564,5): error MSB3073: The command "df --block-size=1M /private/tmp/d20220414-99118-19dsb29/" exited with code 64. [/private/tmp/d20220414-99118-19dsb29/repos/source-build-reference-packages.proj]

@Bo98
Copy link
Member Author

Bo98 commented Apr 14, 2022

Added an inreplace that I think covers it. Should be upstreamed if it works.

@Bo98
Copy link
Member Author

Bo98 commented Apr 14, 2022

GNU coreutils should support -m: https://github.com/coreutils/coreutils/blob/bcfbcef928cd540e53d35fc2869d9def2fedeb84/src/df.c#L1662

Alternative is the BLOCKSIZE environment variable.

@cho-m
Copy link
Member

cho-m commented Apr 14, 2022

Error from trying to use system libunwind on macOS:

CMake Error at /tmp/d20220414-50201-dyxnox/src/runtime.be98e88c760526452df94ef452fff4602fb5bded/artifacts/source-build/self/src/eng/native/functions.cmake:109 (message):
          Cannot find libunwind.  Try installing libunwind8-dev or libunwind-devel.

@Bo98
Copy link
Member Author

Bo98 commented Apr 14, 2022

@cho-m
Copy link
Member

cho-m commented Apr 14, 2022

Specifically, error is happening in https://github.com/dotnet/runtime/blob/v6.0.4/src/native/corehost/apphost/static/CMakeLists.txt#L214-L220

# On *BSD, we always use the libunwind that's part of the OS
if(CLR_CMAKE_TARGET_FREEBSD)
  set(CLR_CMAKE_USE_SYSTEM_LIBUNWIND 1)
endif()

if(CLR_CMAKE_USE_SYSTEM_LIBUNWIND)
    find_unwind_libs(UNWIND_LIBS)

In other CMakeLists.txt, they avoid trying to find library on macOS https://github.com/dotnet/runtime/blob/v6.0.4/src/coreclr/pal/src/CMakeLists.txt#L19-L22

elseif(NOT CLR_CMAKE_TARGET_OSX)
  find_unwind_libs(UNWIND_LIBS)
else()
  add_subdirectory(libunwind)

I guess there are issues with finding macOS libunwind.tbd

@Bo98
Copy link
Member Author

Bo98 commented Apr 14, 2022

libunwind lies in the system dylib and so does not require linker flags, which is why there's a macOS conditional (the else condition was added at a later time for some DWARF handling - it initially just no-oped and it was able to use the system version without issue).

I've pushed what I think the correct patch is - or it's at least consistent with how it worked in the past.

@Bo98
Copy link
Member Author

Bo98 commented Apr 15, 2022

Looks like we're now hitting dotnet/msbuild#7229.

@cho-m
Copy link
Member

cho-m commented Apr 15, 2022

Looks like we're now hitting dotnet/msbuild#7229.

May want to add patch as resource and copy into https://github.com/dotnet/installer/tree/v6.0.104/src/SourceBuild/tarball/patches/msbuild

@chenrui333 chenrui333 removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Apr 15, 2022
@Bo98
Copy link
Member Author

Bo98 commented Apr 16, 2022

@Bo98 Bo98 requested a review from cho-m April 16, 2022 18:58
Copy link
Member

@cho-m cho-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
May need to figure out a livecheck in separate PR as default git tags will end up picking 6.0.2XX.

@Bo98
Copy link
Member Author

Bo98 commented Apr 17, 2022

May need to figure out a livecheck in separate PR as default git tags will end up picking 6.0.2XX.

Seems like it would be something like:

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label May 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-linux-self-hosted Build on Linux self-hosted runner long build Set a long timeout for formula testing outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants