Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Wine 1.7.0 #21641

Closed
wants to merge 1 commit into from
Closed

Wine 1.7.0 #21641

wants to merge 1 commit into from

Conversation

camillol
Copy link
Contributor

@camillol camillol commented Aug 4, 2013

I told you we'd need that devel block again.

def patches
# http://bugs.winehq.org/show_bug.cgi?id=34188
['http://bugs.winehq.org/attachment.cgi?id=45477']
end if build.devel?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to just make the individual patch devel specific in case we need to add others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.6 has the same bug, unfortunately. Eventually the patch will be stable-specific, hopefully.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you not making the whole block here devel specific with the if?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am. I left stable alone on the first pass, then realized it could benefit from this patch too, but forgot to add it, and finally I misunderstood your point.

Actually, I really wanted to make the patch block here based on the new #21648, because patches without checksums make me unconfortable, but because it makes it simpler to conditionalize individual patches.

@LabMem765
Copy link
Contributor

Seems there's a newer version of that patch.

http://bugs.winehq.org/show_bug.cgi?id=34188

@jacknagel jacknagel closed this in 408e48d Aug 11, 2013
handyman5 pushed a commit to handyman5/homebrew that referenced this pull request Oct 7, 2013
Closes Homebrew#21641.

Signed-off-by: Jack Nagel <[email protected]>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants