bgpq3 0.1.19

[job]

Contains a small patch for the Makefile.in file to ensure bgpq3 is installed as $prefix/bin/bgpq3 instead of being installed as $prefix/bin. The patch has been submitted upstream but unsure when they will incorporate.

[adamv]

Please give a link to the upstream patch or bug, thanks.

[mistydemeo]

The audit is finding a top-level man directory - can you pass --mandir= to the configure script so the manpages go in the right location?

[job]

The upstream maintains a small static website with no bugtracker, I've communicated successfully with the author in the past through email.

I expect the author will incorporate the patch in the next release, if he does so I will update the formula accordingly and remove the patch.

[mistydemeo]

Can you just add a comment above the patch to the effect that it's been reported by email and will likely be fixed in the next release?

[mistydemeo]

Sorry, missed that you already had.

[job]

I might not fully understand how these in file patches work, when i try 'brew install --verbose --debug bgpq3.rb' on my local branch, it rejects the patch:

==> Patching
patching file Makefile.in
Hunk #1 FAILED at 29.
1 out of 1 hunk FAILED -- saving rejects to file Makefile.in.rej
Error: Failure while executing: /usr/bin/patch -f -p1 -i 000-homebrew.diff

But after END I've copy pasted the same contents from a test.patch file which does apply cleanly.

[mistydemeo]

@adamv I notice this fairly frequently but haven't dug into what the cause is. Line endings, something else?

[adamv]

Possibly line-endings.

[job]

Found it, tabs in the original file, spaces in my patch.. :-)

[adamv]

GitHub diffs ought to show tabs with a special character

[adamv]

Pulled, sorry for the delay.