Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

swagger-codegen 2.1.4 (new formula) #45360

Closed
wants to merge 1 commit into from
Closed

swagger-codegen 2.1.4 (new formula) #45360

wants to merge 1 commit into from

Conversation

arnested
Copy link
Contributor

No description provided.


head do
url "https://github.com/swagger-api/swagger-codegen.git"
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use head "https://github.com/swagger-api/swagger-codegen.git" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. Copy'n'paste mistake from another more complex formula. Fix coming up in 2 secs.

@arnested
Copy link
Contributor Author

The default check fails for reasons that seems related to the test setup and not to the formula itself?

@arnested
Copy link
Contributor Author

Something/someone trigger a new run of the default check and now it went green.

resource "minimal.yaml" do
url "https://raw.githubusercontent.com/swagger-api/swagger-editor/9ff93eb21264d1274d9269a3930bfb9903b53b2b/app/spec-files/minimal.yaml"
sha256 "9293aaa4968e2ff39d90d2c1be0452234741d7c2649d4b511ab31e2b1ce6ef2d"
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is really small we could inline it in the test:

(testpath/"minimal.yaml").write <<-EOS.undent
  ---
  swagger: '2.0'
  info:
    version: 0.0.0
    title: Simple API
  paths:
    /:
      get:
        responses:
          200:
            description: OK
EOS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed.

@DomT4
Copy link
Member

DomT4 commented Oct 29, 2015

This seems fine to me but will let @bfontaine merge if he's happy since Baptiste did all the review here.

@bfontaine
Copy link
Contributor

Seems like the bottle wasn’t built.

@bfontaine
Copy link
Contributor

@BrewTestBot test this please.

@DomT4
Copy link
Member

DomT4 commented Oct 30, 2015

Blue this time. Wonder why the bottle didn't build last time.

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@DomT4
Copy link
Member

DomT4 commented Oct 31, 2015

Oh, lol, just realised why none of us have been able to pull bottles here:

depends_on :java => "1.7"

We only build bottles against the 1.8 versions of Java, so anything below that we skip over.

@MikeMcQuaid got too enthusiastic earlier and thanked you for something he hadn't actually merged 😉

@DomT4
Copy link
Member

DomT4 commented Oct 31, 2015

Merged now in 5be8732. Thank you!

@DomT4 DomT4 closed this in 5be8732 Oct 31, 2015
@arnested arnested deleted the swagger-codegen-2.1.4 branch October 31, 2015 07:57
@MikeMcQuaid
Copy link
Member

Whoops, thanks @DomT4!

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants