This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
gobject-introspection: add head, add python3 which requires head #45442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +29,7 @@ class GobjectIntrospection < Formula | |||
| depends_on "cairo" | |||
| depends_on "libffi" | |||
| depends_on "python" if MacOS.version <= :mavericks | |||
| depends_on "python3" => :optional | |||
There was a problem hiding this comment.
Just put this in the head block, then you can bin the if build.with?("python3") && !build.head? logic and this line. Also :python3, not "python3".
moyogo
force-pushed
the
gobject-introspection/head
branch
from
c2d99a9
to
375f597
Compare
|
@DomT4 Is this better? |
|
You've broken the formula there 😉 -
|
| system "make", "install" | ||
| if build.head? | ||
| Language::Python.each_python(build) do |python, version| | ||
| sprintf "HEAD #{python} #{version}" |
There was a problem hiding this comment.
Not sure why you need to print here.
moyogo
force-pushed
the
gobject-introspection/head
branch
2 times, most recently
from
0e5d03b
to
39c4c99
Compare
moyogo
force-pushed
the
gobject-introspection/head
branch
from
39c4c99
to
40b7ced
Compare
|
This PR needs to be rebased on top of |
|
Closing due to no response. Feel free to open another PR addressing the comments above. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 support was added on 2015-09-30 in gobject-introspection, after the 1.46.0 release.