Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

diff-so-fancy 0.5.2 #49712

Closed
wants to merge 3 commits into from
Closed

Conversation

stevemao
Copy link
Contributor

@stevemao stevemao commented Mar 2, 2016

No description provided.

@bfontaine
Copy link
Contributor

The test fails:

==> /usr/local/Cellar/diff-so-fancy/0.5.2/bin/diff-so-fancy
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
/usr/local/Cellar/diff-so-fancy/0.5.2/bin/diff-so-fancy: line 74: /usr/local/Cellar/diff-so-fancy/0.5.2/bin/libs/header_clean/header_clean.pl: No such file or directory
Error: diff-so-fancy: failed

The tput message can be fixed by using e.g. ENV["TERM"] = "xterm" at the beginning of the test but for the other error the test needs to be changed.

@scottchiefbaker
Copy link

I'm not really sure what I'm looking at here. The tests are failing on OS X?

That appears to be a tput error. We're only using tput to calculate the width of the terminal. Does a simple tput cols work on that system? I don't have OS X to test with.

@paulirish
Copy link

Going to move this bug here for the moment: so-fancy/diff-so-fancy#101

@OJFord
Copy link
Contributor

OJFord commented Mar 3, 2016

Probably nobody cares (i.e. has used diff-so-fancy for long enough to unwittingly rely on it) but a side-effect of ae402b9 is that diff-highlight is no longer installed to an on-$PATH location.

As I say I don't think this matters, it's just maybe worth noting/acknowledging.

@OJFord
Copy link
Contributor

OJFord commented Mar 3, 2016

1/3 Travis seems to fail due to a network error installing gems.

@bfontaine Original issue is fixed, can you re-run the test (or ignore if you're happy to)? :)

@bfontaine
Copy link
Contributor

@OJFord Don’t worry about Travis, only the “default” build counts 😃

@bfontaine
Copy link
Contributor

Thank you for your contribution to Homebrew, @stevemao; we appreciate it! 🎉

@bfontaine bfontaine closed this in e2b7e26 Mar 4, 2016
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants