Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find and remove child widgets from the document context #1002

Merged
merged 4 commits into from
Oct 7, 2021
Merged

Find and remove child widgets from the document context #1002

merged 4 commits into from
Oct 7, 2021

Commits on Sep 23, 2021

  1. Find and remove child widgets from the document context 

    When removing a field from the document, we need to remove the children of the field first; otherwise, some renderers will still see the remnants and display these dangling widgets.
    @andrew-trefethen
    andrew-trefethen committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    12ce7d7 View commit details
    Browse the repository at this point in the history

  2. use for loop instead of .forEach and .toArray

    @andrew-trefethen
    andrew-trefethen committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    2506331 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. add test to verify that widget child references are cleaned up

    @andrew-trefethen
    andrew-trefethen committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    b09a2f3 View commit details
    Browse the repository at this point in the history

  2. Add integration tests to test 1 page 5 

    We add and remove a widget to page 5. Text above the location should direct the individual to look for any visual remnants of a field
    @andrew-trefethen
    andrew-trefethen committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    62a44df View commit details
    Browse the repository at this point in the history