Cleanup 745 #769
Merged
Cleanup 745 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* more ViewerPreferences address issue #744 * PDFHexString ViewerPreferences * Update ViewerPreferences.ts * neaten ViewerPreferences * type assertIsOneOf values * clearer documentation of viewerPreferences * Update tsconfig target * README with viewer pref * tests for viewer preferences * more ViewerPreferences address issue #744 * revert to ES5 target * fix tsconfig es case ensure it does not show up as a change in the diff * address Hopding coments 1 * minor viewerpref doc changes * doc viewerPref with pageMode * set pagemode * test existing viewerPrefs in doc * document viewerPref enums * lint viewerPreferences * comment linting * comments in 0 printpage index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #745