Skip to content

Commit

Permalink
rpc, internal/cmdtest: increase timeout in tests (ethereum#27083)
Browse files Browse the repository at this point in the history
This change gives the cmd-tests have a bit more time to finish before getting forcibly torn down.
  • Loading branch information
jsvisa authored and devopsbo3 committed Nov 10, 2023
1 parent 33ddc57 commit cebac05
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/geth/consolecmd_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func TestAttachWelcome(t *testing.T) {
waitForEndpoint(t, endpoint, 3*time.Second)
testAttachWelcome(t, geth, endpoint, httpAPIs)
})
geth.ExpectExit()
geth.Kill()
}

func testAttachWelcome(t *testing.T, geth *testgeth, endpoint, apis string) {
Expand Down
2 changes: 1 addition & 1 deletion internal/cmdtest/test_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ func (tt *TestCmd) Kill() {
}

func (tt *TestCmd) withKillTimeout(fn func()) {
timeout := time.AfterFunc(5*time.Second, func() {
timeout := time.AfterFunc(30*time.Second, func() {
tt.Log("killing the child process (timeout)")
tt.Kill()
})
Expand Down
2 changes: 1 addition & 1 deletion rpc/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var (
const (
// Timeouts
defaultDialTimeout = 10 * time.Second // used if context has no deadline
subscribeTimeout = 5 * time.Second // overall timeout eth_subscribe, rpc_modules calls
subscribeTimeout = 10 * time.Second // overall timeout eth_subscribe, rpc_modules calls
)

const (
Expand Down

0 comments on commit cebac05

Please sign in to comment.