This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: migrate tests to React Testing Library #2516
test: migrate tests to React Testing Library #2516
Changes from 28 commits
5eea518
0a9570f
865dcfd
7c00669
af591cb
8159479
c4e194b
0fc87c2
120995a
1b2f258
147013b
a264672
ed71f41
d84a4e0
f55e09b
53ed6e2
b4f1dbc
f760ef8
3748223
bceb054
5ef29a1
94fe727
92c027d
ffa4d9e
00064ec
cc46717
c9f73f3
d64822e
0e7d25e
2594cde
ad4c873
67101bd
9fa9fd3
f028b10
46c77dc
b3be647
059bac4
f12f344
0638d44
baf9c2b
ce51bca
ce82875
988ad76
bfd107f
31a0a70
cb00401
a58d186
7fe5ee0
d2866f2
42f5f8d
9e69c0b
791bfdc
b028a4d
18083f6
6fd366f
4aaa334
0dbddc1
b564ccf
ffeae97
2e0a242
6bb0bfa
855611f
1a49469
775c8d6
2a8f982
01c1b52
1957426
f6d8271
2899482
6bbd731
733b26e
53be3d1
c5fab6b
39d5aa4
4dff109
ca47677
29c4c76
67d6d29
26e35dd
e1aa92b
2192e60
405ec6d
49f96da
63e7bb4
f18900b
abc6718
081246c
941c724
7a45922
4f154e3
7a162f2
cb47735
77266c0
8a88313
5b8d39c
8da5bc4
f056391
afee1a2
a42b3ee
b055637
12d80ce
7ebd924
0cb3562
13b8e41
7d4a8b0
db92fcb
fd539b9
21aa5f1
19d2517
d4d8e96
ed61bcf
99a0752
f7e8606
1f1c109
789fff8
5992dad
a22a455
9dc8111
f3d5f0e
cde4a39
2015a17
3add6f6
fa037d6
a3c09a8
c06b426
3862c6e
9940f72
4903ba5
026e44d
3aa4b89
5d6952c
8d98934
ac35b21
7c53673
e9ee1f8
76f5280
2bdc2e0
4763780
692893c
386574b
e94d817
f3139e8
8693002
d736383
6ba9e6a
94f5b9f
05d2e17
67c29c7
f12b4db
467f063
a9acd72
3115437
5e4eba4
4cf0e76
31c2b1e
2e19466
c47ce48
a1b4eb2
b17f15e
90a1757
6aa7654
0c1ac98
8782d24
d5ae24a
118d285
e81e959
86122a9
fc0f308
6727764
1e7ff86
a2e644b
e707c77
d7659bc
40df690
afb2a77
13dea3e
f3e9b12
6835c6e
f97d303
0ca15f2
d34999a
128a9ff
d7090b4
99326ff
f6ec2e5
70a1bc0
8722ac7
06e143c
78f0566
8a845dc
7898ddf
b0a87e1
1d3cf9e
3131da3
e72e76f
e92f559
051048e
03fcc58
88c3e47
35af11a
c9e23d1
3d019ca
f824248
92e996a
0ffa12f
012bd0a
7c884ab
6c62b5b
4943047
0bf14fd
63499e5
671b0b3
e80383e
f342ec5
21487e5
e5e83e3
c8c61a3
7ac2655
337cdb7
4ec48e8
aa7b639
967e52c
69c5e13
9821b83
402392c
8ccb322
8e9228a
acafa59
21700c5
ac3efd2
0b5535a
84aba16
8d27975
07bbb35
45451f3
a57cab7
998a785
8d82cd8
0182da3
3888dc5
fbd79d9
b6f8d3d
7fb20b0
758daba
4860ebb
6f3567c
4e7e446
1ea596f
ac4e1e9
a5f3b13
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to look for a header that has appointments rather than the new appointments button?
To me, the header better represents we are on the right page rather than the button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps.
@nobrayner @codyarose thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Changed to check for the heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the dashboard content eventually get's implemented "example" will no longer exist in the document. Does this mean we would have to change this test at that time? or should we rather check for "Dashboard"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and Yes 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (to be merged)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this test will fail once the dashboard content is implemented and "example" is no longer there. Perhaps we should rather check for "dashboard" as that is almost guaranteed to always exist? There are a few other instances of this same check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. #2516 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (to be merged)