fix(lab): In New lab request make the visit field required

[SamuelQZQ]

Fixes #2551 .

Changes proposed in this pull request:

• I make the NewLabRequest use the exact same method to solve the null visit issue. NewImagingRequest.tsx line65
• My concern is, we use the as Option[] at line 57. So that the type of the variable visits is not right. It should be Option[] | null. Maybe we should do some refactor in NewImagingRequest.tsx and NewLabRequest.tsx to fix this wrong type. Otherwise, it may lead to other bugs in the future.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/8hgo1k2s2
✅ Preview: https://hospitalrun-frontend-git-fork-samuelqzq-lab-request-bug.hospitalrun.now.sh

[matteovivona]

Could you please sign our CLA? Thank you https://cla.js.foundation/HospitalRun/hospitalrun-frontend?pullRequest=2552

[SamuelQZQ]

I have signed the CLA

[blestab]

I have opened a new session in another chrome instance and I can see the visit option, which is not required, which i guess if why this bug occurs. So if you make the visit required then the issue should be resolved.

Looking good @SamuelQZQ I can see we are no longer crashing if there is no visit specified, however since the visit is required for each lab request we need to make the visit field required as it is on the imaging request.

[blestab]

Thanks @SamuelQZQ

This is now behaving the same as the Request Imaging. I did notice however that Request Imaging (like this latest change) does not prevent saving when visit is not selected, even though it shows visit as required.

Will create separate issues for these though unless you want to deal with the Lab issue in this PR? If you prefer we work on it in a separate issue that's also alright, I can go ahead and approve this one so we can create the new issue?

[chadian]

This somewhat relates to my PR #2555 to make sure visits is an empty array when a patient is created. This would help with the "crashing" part but doesn't change the fact if it should be a required field or not (what is covered in this PR).

[SamuelQZQ]

@blestab I prefer to work on it in a separate issue. Let's complete this one. I will test more carefully in future work.

[blestab]

@blestab I prefer to work on it in a separate issue. Let's complete this one. I will test more carefully in future work.

Awesome! thanks @SamuelQZQ

@tehkapa this one now looks good.

[blestab]

This somewhat relates to my PR #2555 to make sure visits is an empty array when a patient is created. This would help with the "crashing" part but doesn't change the fact if it should be a required field or not (what is covered in this PR).

Yeah just noticed that. I have since created a separate issue for enforcing the 'required visit' behavior