ClassLoader synchronization removed

locking on classloader fails, related issue #39
HotswapProjects · Dec 8, 2016 · fd1f2dd · fd1f2dd
1 parent 6d7f75d
commit fd1f2dd
Showing 1 changed file with 17 additions and 17 deletions.
diff --git a/hotswap-agent-core/src/main/java/org/hotswap/agent/util/HotswapTransformer.java b/hotswap-agent-core/src/main/java/org/hotswap/agent/util/HotswapTransformer.java
@@ -233,24 +233,24 @@ protected void ensureClassLoaderInitialized(final ClassLoader classLoader, final
                     PluginManager.getInstance().getScheduler().scheduleCommand(new Command() {
                         @Override
                         public void executeCommand() {
-                            //
-                            // Synchronize class loader to avoid DEADLOCKs on PluginManager.INSTANCE.
-                            //
-                            // Explanation:
-                            // There are 2 possible places from which the PluginManager.getInstance().initClassLoader() can be called:
-                            // 1. sun.instrument.TransformerManager.transform ->
-                            //                   org.hotswap.agent.util.HotswapTransformer.transform ->
-                            //                              PluginClassFileTransformer.transform() ->
-                            //                                          PluginManager.initClassLoader()
-                            //    In this case class loader is locked before call sun.instrument.TransformerManager.transform, subsequently
-                            //    an attempt to get PluginManager.INSTANCE lock is done in  PluginManager.initClassLoader()
-                            // 2. From this fallback. The lock is acquired in PluginManager.initClassLoader(), then an attempt to get ClassLoader
-                            //    lock is done when ClassLoaderDefineClassPatcher makes copy of HA'classes in the new classloader.
-                            //
-                            // conclusion : classloader must be locked before PluginManager.getInstance().initClassLoader is called.
-                            synchronized (classLoader) {
+//                            //
+//                            // Synchronize class loader to avoid DEADLOCKs on PluginManager.INSTANCE.
+//                            //
+//                            // Explanation:
+//                            // There are 2 possible places from which the PluginManager.getInstance().initClassLoader() can be called:
+//                            // 1. sun.instrument.TransformerManager.transform ->
+//                            //                   org.hotswap.agent.util.HotswapTransformer.transform ->
+//                            //                              PluginClassFileTransformer.transform() ->
+//                            //                                          PluginManager.initClassLoader()
+//                            //    In this case class loader is locked before call sun.instrument.TransformerManager.transform, subsequently
+//                            //    an attempt to get PluginManager.INSTANCE lock is done in  PluginManager.initClassLoader()
+//                            // 2. From this fallback. The lock is acquired in PluginManager.initClassLoader(), then an attempt to get ClassLoader
+//                            //    lock is done when ClassLoaderDefineClassPatcher makes copy of HA'classes in the new classloader.
+//                            //
+//                            // conclusion : classloader must be locked before PluginManager.getInstance().initClassLoader is called.
+//                            synchronized (classLoader) {
                                 PluginManager.getInstance().initClassLoader(classLoader, protectionDomain);
-                            }
+//                            }
                             //
                             //
                             //