호미 정렬, 슬랙 메시지 prod 환경에서만 오도록 수정 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyejungg
requested changes
Oct 18, 2022
Comment on lines
133
to
146
| public int compareTo(Onboarding o) { | ||
| TestScore t1 = getTestScore(); | ||
| TestScore t2 = o.getTestScore(); | ||
| if (t1 == null && t2 != null) { | ||
| return 1; | ||
| } | ||
| if (t1 != null && t2 == null) { | ||
| return -1; | ||
| } | ||
| if (t1 == null && t2 == null) { | ||
| return 0; | ||
| } | ||
| return t1.getCreatedAt().compareTo(t2.getCreatedAt()); | ||
| } |
There was a problem hiding this comment.
성향테스트를 안한 사람 중 방 참여 시간 순서로 정렬하는 부분은 없는 것 같아요 ?!
| @@ -40,9 +41,10 @@ public UserPersonalityInfoResponse getUsersInfo(Long userId) { | |||
| List<Participate> participates = room.getParticipates(); | |||
| List<Onboarding> onboardings = participates.stream() | |||
| .map(Participate::getOnboarding) | |||
| .sorted(Comparator.comparing(onboarding -> onboarding.getTestScore().getUpdatedAt())) | |||
| .sorted(Onboarding::compareTo) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers