사용자 탈퇴 요청 시 피드백 받는 부분 수정 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orijoon98
reviewed
Dec 22, 2022
Comment on lines
22
to
25
| if (comment.isBlank()) { | ||
| return UserDeleteResponse.builder() | ||
| .totalDeleteUserCount(totalDeleteUserCount) | ||
| .totalDeleteUserList(users.stream() |
There was a problem hiding this comment.
null 이 안들어오게 바껴서 이 부분 comment 값에 상관없이 처리하고
createUserDeleteMessage 에서 comment 비교하는 부분을 수정하면
코드가 더 깔끔해질 것 같은데 어떠신가요?!
There was a problem hiding this comment.
좋은 의견입니다! if (!userDeleteResponse.getComment().isBlank()) 괜찮을까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers