-
Notifications
You must be signed in to change notification settings - Fork 196
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #418 from HubSpot/feature/bampVersion
5.2.0
- Loading branch information
Showing
4 changed files
with
23 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,24 +6,28 @@ agree to not be a jerk. | |
## Getting Started | ||
|
||
- Fork, then clone the repo: | ||
``` | ||
|
||
```bash | ||
git clone [email protected]:your-username/hubspot-php.git | ||
``` | ||
|
||
- Set up your machine: | ||
``` | ||
|
||
```bash | ||
composer install | ||
``` | ||
|
||
- Make your change. Add test for your changes. Make the tests pass, e.g.: | ||
``` | ||
|
||
```bash | ||
vendor/bin/phpunit tests/integration/Endpoints/TimelineTest | ||
``` | ||
|
||
or you can run tests with docker: | ||
1. Copy .env.template to .env | ||
2. Specify data in .env (for most tests it is enough to specify HUBSPOT_TEST_API_KEY) | ||
3. `docker-compose up --build` | ||
|
||
1. Copy `.env.template` to `.env` | ||
2. Specify data in `.env` (for most tests it is enough to specify `HUBSPOT_TEST_API_KEY`) | ||
3. `docker-compose up --build` | ||
|
||
- Push to your fork and [submit a pull request][pr]. | ||
|
||
|
@@ -35,9 +39,9 @@ some changes or improvements or alternatives. | |
|
||
Some things that will increase the chance that your pull request is accepted: | ||
|
||
* Write tests. | ||
* Follow PSR-2 [style guide][style]. | ||
* Write a [good commit message][commit]. | ||
- Write tests. | ||
- Follow PSR-2 [style guide][style]. | ||
- Write a [good commit message][commit]. | ||
|
||
[style]: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md | ||
[commit]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters