Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php8.1 deprecated message #378

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

georgesamy
Copy link
Contributor

We got the following message in our project when upgrading to php8.1, this PR will fix these deprecation warnings

PHP Deprecated:  Return type of SevenShores\Hubspot\Http\Response::offsetExists($offset) 
should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the 
#[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in 
/srv/backend/vendor/hubspot/hubspot-php/src/Http/Response.php on line 65
PHP Deprecated:  Return type of SevenShores\Hubspot\Http\Response::offsetGet($offset)
 should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the
 #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in
 /srv/backend/vendor/hubspot/hubspot-php/src/Http/Response.php on line 77
PHP Deprecated:  Return type of SevenShores\Hubspot\Http\Response::offsetSet($offset, $value)
 should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the
 #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in 
/srv/backend/vendor/hubspot/hubspot-php/src/Http/Response.php on line 90
PHP Deprecated:  Return type of SevenShores\Hubspot\Http\Response::offsetUnset($offset) 
should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the 
#[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in 
/srv/backend/vendor/hubspot/hubspot-php/src/Http/Response.php on line 100

We have version v4.0.1 installed

@ksvirkou-hubspot ksvirkou-hubspot merged commit e335bf8 into HubSpot:master Feb 15, 2022
@jmglsn
Copy link

jmglsn commented May 5, 2022

@ksvirkou-hubspot can you please create a new release with this fix?

@jwage
Copy link

jwage commented Jul 26, 2022

Can we create a new release for this?

@jmglsn
Copy link

jmglsn commented Jul 27, 2022

That would be cool... the warnings are annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants