Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve watchdog reliability. Add panic button driver. Simplify some code repetition #16

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

cmorse
Copy link
Collaborator

@cmorse cmorse commented Aug 17, 2021

This should improve how reliable the watchdog checking is. I've had many times where the websocket would be disconnected, but the watchdog would not catch it. I updated the watchdog so that it is based on the last time that a msg was received from the websocket, rather than the last time that 'refresh()` was called

I've been using this code for 3-4 months and the new watchdog code has reliably recovered the websocket connection many times.

@samyun
Copy link

samyun commented Sep 25, 2021

@cmorse planning on checking this in?

@cmorse
Copy link
Collaborator Author

cmorse commented Sep 26, 2021

I don't have write access to this repo

@jedbro
Copy link

jedbro commented Dec 21, 2021

@cmorse - Do we know who has write access?
I'd like to get this checked in and add support for additional new Ring devices.

@samyun
Copy link

samyun commented Dec 22, 2021

@ardichoke has write access, looking at previous PRs in this project.

@csteele-PD and @djdizzyd are both listed as org members of HubitatCommunity with recent activity - either of you have write access and can look at this and #18?

@Banner-Keith
Copy link
Member

Sorry guys. I didn't get any notifications whatsoever about this. I just saw the tag tonight in the community thread. This looks good to me.

@Banner-Keith Banner-Keith merged commit ca1412f into HubitatCommunity:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants