enh: improve read perf of http accessor by using requests.Session #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://requests.readthedocs.io/en/latest/user/advanced/#session-objects , it appears that by using
requests.Session
, the underlying TCP connection will be reused, which should drastically improve repeated get requests to the same host.From the (admittedly) rough test script[1], we see promising improvement (execution time cut by ~50% in sync reads and ~30% in threaded reads) [2]
[1] rough script used for testing both sync and threaded operations, we used
time python <script_name>.py
and manually recorded the result[2] truncated result