-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: adding support for sharded precomputed #35
Conversation
maint: minor refactor
test: migrated & fixed current tests
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 92.61% 93.96% +1.34%
==========================================
Files 25 28 +3
Lines 1490 2138 +648
Branches 219 308 +89
==========================================
+ Hits 1380 2009 +629
- Misses 63 75 +12
- Partials 47 54 +7 ☔ View full report in Codecov by Sentry. |
@ylep I believe the PR is mostly ready. Can you take a look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, I want to thank you a lot @xgui3783 for adding this very significant feature to neuroglancer-scripts! I had been aware of the existence of that sharded storage format, but saw that it was a complex feature to implement so I did not find the time to do so myself.
Next, I apologize for taking so long to review the code. Actually, this is a large amount of code so I have not been able to review it as deeply as I would like. Most of my comments are rather superficial unfortunately; but on the other hand I have no doubt that you have structured the code in a very good way.
My comments are in-line with the code, I'd just like to add one general comment: the new files that you introduced, and those that you contributed to substantially, should have a short copyright header added / updated, in the style of:
https://github.com/HumanBrainProject/neuroglancer-scripts/blob/53e8042411cd6c52d80159f9f8a486e09c877ed1/src/neuroglancer_scripts/chunk_encoding.py#L1C1-L4C74
In particular, the files that contain third-party code should have the copyright and licence of that code included.
With these few minor changes addressed, I will be happy to approve and merge this PR, and make a new release of neuroglancer-scripts!
@ylep I have added an additional commit, which hopefully address most if not all of your concerns. can you take another look when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xgui3783 Huge thanks for implementing this feature, it looks to me in a very good state now!
This feature alone is probably worth a 1.2.0 release, don't you think?
Thanks @ylep for the quick response. I would fully support a 1.2.0 release. |
This is a PR adding support for sharded precomputed
This PR should (hopefully) support both read/write from local/http, much like the existing
FileAccessor
andHttpAccessor
.I will be polishing the PR by:
in the coming days.
I would like already to gauge if: