Don't trigger monitoring daemons for non standard environments (#333)

* limit cloudwatch rule to default envs * update for pr comments
HumanCellAtlas · Mar 29, 2019 · bfd9ca3 · bfd9ca3
1 parent 3d67596
commit bfd9ca3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/terraform/modules/upload-service/batch_watcher.tf b/terraform/modules/upload-service/batch_watcher.tf
@@ -117,12 +117,14 @@ resource "aws_cloudwatch_event_rule" "batch_watcher_hourly_rule" {
     name = "batch-watcher-every-hour-${var.deployment_stage}"
     description = "Fires every hour"
     schedule_expression = "cron(0 * * * ? *)"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
 }
 
 resource "aws_cloudwatch_event_target" "hourly_batch_watcher" {
     rule = "${aws_cloudwatch_event_rule.batch_watcher_hourly_rule.name}"
     target_id = "batch_watcher_lambda"
     arn = "${aws_lambda_function.batch_watcher_lambda.arn}"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
 }
 
 resource "aws_lambda_permission" "allow_cloudwatch_to_call_batch_watcher" {
@@ -131,4 +133,6 @@ resource "aws_lambda_permission" "allow_cloudwatch_to_call_batch_watcher" {
     function_name = "${aws_lambda_function.batch_watcher_lambda.function_name}"
     principal = "events.amazonaws.com"
     source_arn = "${aws_cloudwatch_event_rule.batch_watcher_hourly_rule.arn}"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
+
 }
diff --git a/terraform/modules/upload-service/health_check_lambda.tf b/terraform/modules/upload-service/health_check_lambda.tf
@@ -95,12 +95,14 @@ resource "aws_cloudwatch_event_rule" "daily" {
     name = "dcp-upload-daily-health-check-${var.deployment_stage}"
     description = "Fires every day at 13:00 UTC"
     schedule_expression = "cron(0 13 * * ? *)"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
 }
 
 resource "aws_cloudwatch_event_target" "daily_health_check" {
     rule = "${aws_cloudwatch_event_rule.daily.name}"
     target_id = "upload_health_check_lambda"
     arn = "${aws_lambda_function.upload_health_check_lambda.arn}"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
 }
 
 resource "aws_lambda_permission" "allow_cloudwatch_to_call_health_check" {
@@ -109,4 +111,6 @@ resource "aws_lambda_permission" "allow_cloudwatch_to_call_health_check" {
     function_name = "${aws_lambda_function.upload_health_check_lambda.function_name}"
     principal = "events.amazonaws.com"
     source_arn = "${aws_cloudwatch_event_rule.daily.arn}"
+    count = "${var.deployment_stage == "prod" || var.deployment_stage == "staging" || var.deployment_stage == "integration" || var.deployment_stage == "dev" ? 1 : 0}"
+
 }