Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable warm starting adversarial algorithms w/ behavior cloning #602

Closed
wants to merge 1 commit into from

Conversation

samuelarnesen
Copy link
Contributor

@samuelarnesen samuelarnesen commented Oct 30, 2022

Description

Addresses issue #587

Enables out-of-the-box warm starting of a GAIL/AIRL training run w/ behavior cloning

Testing

New unit test

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #602 (5d3b8bb) into master (622092c) will increase coverage by 1.21%.
The diff coverage is 100.00%.

❗ Current head 5d3b8bb differs from pull request most recent head 24a88b8. Consider uploading reports for the commit 24a88b8 to get more accurate results

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   96.31%   97.52%   +1.21%     
==========================================
  Files          89       85       -4     
  Lines        8618     8130     -488     
==========================================
- Hits         8300     7929     -371     
+ Misses        318      201     -117     
Impacted Files Coverage Δ
src/imitation/scripts/config/train_adversarial.py 71.95% <100.00%> (+12.69%) ⬆️
src/imitation/scripts/train_adversarial.py 95.18% <100.00%> (+1.59%) ⬆️
src/imitation/scripts/train_imitation.py 96.20% <100.00%> (+3.55%) ⬆️
tests/scripts/test_scripts.py 100.00% <100.00%> (ø)
src/imitation/scripts/parallel.py 64.81% <0.00%> (-1.23%) ⬇️
.../imitation/scripts/train_preference_comparisons.py 96.87% <0.00%> (-0.35%) ⬇️
src/imitation/algorithms/mce_irl.py 95.95% <0.00%> (-0.22%) ⬇️
src/imitation/data/types.py 98.19% <0.00%> (-0.02%) ⬇️
tests/test_experiments.py 100.00% <0.00%> (ø)
tests/data/test_rollout.py 100.00% <0.00%> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ernestum
Copy link
Collaborator

@samuelarnesen @AdamGleave are we still interested in merging this PR? If so I would review it and resolve the conflicts.

@AdamGleave
Copy link
Member

It's a feature I'd like to have. But the solution ended up quite messy, I think we might need a more significant refactor of our scripts to accommodate it cleanly, so I'm inclined to icebox it.

FYI samuelarnesen worked on this during his work trial which is now over, so out of respect for his time let's try and resolve this without his involvement.

@ernestum
Copy link
Collaborator

I rebased/squashed this onto the current master. Before properly cleaning up I would like to decide if we keep sacred or not in #79

@ernestum ernestum added this to the Release v1.x milestone May 25, 2023
@AdamGleave AdamGleave closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants