Implement printing initials in xnames
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `xnames(entry; names=:last)` to print first name initials (as stated in the documentation) and `xnames(entry; names=:lastonly)` to print last names only. Add an option `and` to use put " and " between the last two names. Closes Humans-of-Julia#48
|
I don't know what's going on with the failing test… I'm seeing the same failure locally on my macBook, but they're failing for the current |
|
Sorry for the long silence. I think we test that the output is similar to the content of some files. Probably, I need to regenerate those files to fit your changes. I will have a look next week. |
|
Sorry, I went back to this a bit late ... I have some odd behavior now with this PR (probably changes from different places). I need to refactor most of the library anyway, so I will incorporate your PR at that point. Thank you and sorry for the long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
xnames(entry; names=:last)to print first name initials (as stated in the documentation) andxnames(entry; names=:lastonly)to print last names only.Add an option
andto use put " and " between the last two names.Closes #48