[Feat] Optimize UI #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- you can receive components that match the name and class type that you handed over to the param - complete test code Signed-off-by: Hyeon-Uk <[email protected]>
- TextArea can't embed hyperlink. but console view can do that. - User can experience debugging in console environments - Layout had been changed. Signed-off-by: Hyeon-Uk <[email protected]>
- MyTestListPanel is used globally through multiple files. - So we need the way to handle this component easily - I think, using component manager is better then singleton pattern because singleton can't remove own object and can waste memories. Signed-off-by: Hyeon-Uk <[email protected]>
- I think ToolWindowFactory doesn't have any responsbility about designing main view. - So, I had extracted this mainView class. - MyTestListPanel is always created by MyMainView. so, in my opinion, protected is more appropriate than public. Signed-off-by: Hyeon-Uk <[email protected]>
- implements layout according to the position of the toolWindow. - refactoring codes.
Hyeon-Uk
added a commit
that referenced
this pull request
Jan 14, 2024
- Disable closing `support window` - Layout setting according to the position of the toolWindow - Embed console view on `Result Area` - Refactoring for Clean Code and Object-oriented Coding Signed-off-by: Hyeon-Uk <[email protected]>
Merged
Hyeon-Uk
added a commit
that referenced
this pull request
Jan 16, 2024
* [Feat] Optimize UI (#3) - Disable closing `support window` - Layout setting according to the position of the toolWindow - Embed console view on `Result Area` - Refactoring for Clean Code and Object-oriented Coding * [Fix] Verification error (#5) Fixed an error that failed verification due to carriage return characters by deleting all carriage return characters. Signed-off-by: Hyeon-Uk <[email protected]>
Merged
Hyeon-Uk
added a commit
that referenced
this pull request
Jan 16, 2024
* [Feat] Optimize UI (#3) - Disable closing `support window` - Layout setting according to the position of the toolWindow - Embed console view on `Result Area` - Refactoring for Clean Code and Object-oriented Coding * [Fix] Verification error (#5) Fixed an error that failed verification due to carriage return characters by deleting all carriage return characters. Signed-off-by: Hyeon-Uk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related : #1
Change layout and embed console view.
Extract main view code in myWindowFactory
Object Oriented Programming Principles, window factory doesn't have any responsibility about designing main view.Remove MyTestListPanel's singleton pattern
The components appear immediately.
[Before]
[After]
Implement vertical layout
[Before] Layout is always setted horizontal layout.
[After] Layout setting according to the position of the toolWindow
