Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_connection_cyclic doesn't need to be recursive #5

Closed
HyperCodec opened this issue Feb 12, 2024 · 1 comment
Closed

is_connection_cyclic doesn't need to be recursive #5

HyperCodec opened this issue Feb 12, 2024 · 1 comment
Assignees
@HyperCodec
Labels
enhancement New feature or request

Comments

@HyperCodec
Copy link
Owner

The recursiveness of the is_connection_cyclic makes it hard for contributors to understand and should be refactored to a loop for readability.
@HyperCodec HyperCodec added bug Something isn't working enhancement New feature or request labels Feb 12, 2024
@HyperCodec HyperCodec self-assigned this Feb 12, 2024
@HyperCodec HyperCodec changed the title is_connection_cycling doesn't need to be recursive is_connection_cyclic doesn't need to be recursive Feb 12, 2024
@HyperCodec HyperCodec removed the bug Something isn't working label Feb 14, 2024
@HyperCodec
Copy link
Owner Author

#13 should fix this with DFS, will close once I solve the other issues in the PR and then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HyperCodec HyperCodec

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HyperCodec