Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing mutations #13

Merged
merged 11 commits into from
Feb 20, 2024
Merged

add missing mutations #13

merged 11 commits into from
Feb 20, 2024

Conversation

HyperCodec
Copy link
Owner

No description provided.

@HyperCodec HyperCodec added the enhancement New feature or request label Feb 14, 2024
@HyperCodec HyperCodec self-assigned this Feb 14, 2024
@HyperCodec HyperCodec changed the title 8 more mutations add missing mutations Feb 14, 2024
@HyperCodec
Copy link
Owner Author

Now there's an index error with mutations. Probably caused by the removeneuron mutation.

@HyperCodec
Copy link
Owner Author

HyperCodec commented Feb 14, 2024

also appears to have a deadlock.

@HyperCodec
Copy link
Owner Author

deadlock and index are rng-based so its probably mutations causing that.

@HyperCodec
Copy link
Owner Author

runnable.rs:124 and topology.rs:115 both have index errors

@HyperCodec
Copy link
Owner Author

not entirely sure why runnable has index errors still if the shifting is working. deadlock still probably exists (although haven't reproduced since these changes), not sure where that happens either.

@HyperCodec
Copy link
Owner Author

ok i think the runnable issue is when the last neuron of hidden layers is deleted.

previous commit did not fix the topology index issue fully btw

@HyperCodec
Copy link
Owner Author

just looked at backtrace, topology index error is caused by is_connection_cyclic somehow. I still think the root cause is mutation not properly fixing the input locations, but not sure why this is happening.

@HyperCodec
Copy link
Owner Author

I apparently just used the same variable name twice (oopsies). Runnable index still errors but not seeing any topology index errors.

@HyperCodec
Copy link
Owner Author

Deadlock is still an issue

@HyperCodec
Copy link
Owner Author

Might not actually be a deadlock, could be just infinite loop.

@HyperCodec
Copy link
Owner Author

process_neuron is still running into the same cyclic connection issue, I believe this might just be caused by a conceptual flaw with it. I must be doing something wrong if it has gone through so many revisions and it still has this bug.

@HyperCodec
Copy link
Owner Author

no sure how the fuck this happened but input layer is using output layer
image

@HyperCodec
Copy link
Owner Author

ok so I'll restate the issues:

  1. neurons inputs keep pointing to output layer somehow, causing borrow errors
  2. neurons keep pointing to missing hidden layer locations, causing index errors.
  3. i have no clue where in mutation any of these issues occur

@HyperCodec
Copy link
Owner Author

welp looks like I spent a week trying to debug a simple swapped-variable issue. glad to see that I'm using my time wisely

@HyperCodec HyperCodec merged commit cf1dd51 into dev Feb 20, 2024
3 checks passed
@HyperCodec HyperCodec deleted the 8-more-mutations branch February 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant