Skip to content

Commit

Permalink
don't permit >128 bit integers
Browse files Browse the repository at this point in the history
  • Loading branch information
tybug committed May 27, 2024
1 parent 6a981fc commit 41b15e3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 5 deletions.
12 changes: 10 additions & 2 deletions hypothesis-python/src/hypothesis/internal/conjecture/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -1072,9 +1072,17 @@ def __repr__(self):

def ir_value_permitted(value, ir_type, kwargs):
if ir_type == "integer":
if kwargs["min_value"] is not None and value < kwargs["min_value"]:
min_value = kwargs["min_value"]
max_value = kwargs["max_value"]
shrink_towards = kwargs["shrink_towards"]
if min_value is not None and value < min_value:
return False
if kwargs["max_value"] is not None and value > kwargs["max_value"]:
if max_value is not None and value > max_value:
return False

if (max_value is None or min_value is None) and (
value - shrink_towards
).bit_length() >= 128:
return False

return True
Expand Down
18 changes: 15 additions & 3 deletions hypothesis-python/tests/conjecture/test_ir.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,21 @@ def test_all_children_are_permitted_values(ir_type_and_kwargs):
@pytest.mark.parametrize(
"value, ir_type, kwargs, permitted",
[
(0, "integer", {"min_value": 1, "max_value": 2}, False),
(2, "integer", {"min_value": 0, "max_value": 1}, False),
(10, "integer", {"min_value": 0, "max_value": 20}, True),
(0, "integer", {"min_value": 1, "max_value": 2, "shrink_towards": 0}, False),
(2, "integer", {"min_value": 0, "max_value": 1, "shrink_towards": 0}, False),
(10, "integer", {"min_value": 0, "max_value": 20, "shrink_towards": 0}, True),
(
int(2**128 / 2) - 1,
"integer",
{"min_value": None, "max_value": None, "shrink_towards": 0},
True,
),
(
int(2**128 / 2),
"integer",
{"min_value": None, "max_value": None, "shrink_towards": 0},
False,
),
(
math.nan,
"float",
Expand Down

0 comments on commit 41b15e3

Please sign in to comment.