Skip to content

Commit

Permalink
fix: further reduce min force scan
Browse files Browse the repository at this point in the history
  • Loading branch information
@cdnninja
cdnninja authored Sep 8, 2023
1 parent 4271439 commit 0c73242
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion custom_components/kia_uvo/config_flow.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def __init__(self, config_entry: ConfigEntry) -> None:
default=self.config_entry.options.get(
CONF_FORCE_REFRESH_INTERVAL, DEFAULT_FORCE_REFRESH_INTERVAL
),
): vol.All(vol.Coerce(int), vol.Range(min=45, max=999)),
): vol.All(vol.Coerce(int), vol.Range(min=90, max=999)),
vol.Required(
CONF_NO_FORCE_REFRESH_HOUR_START,
default=self.config_entry.options.get(
Expand Down

2 comments on commit 0c73242

@GameGrime
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to restrict the users to having a minimum forced update on the car status to 90 minutes, Effectively doubling the previous minimum.
I see why this change is useful, with reports of 12v battery drain effecting systems.
But it also restricts the experience for those who are willing to "play with fire".

Does this change restrict the user from specifying anything below 90 minutes manually?
What is the default value of the force update number upon install of the addon?

Is it possible to allow the user access to below 90 minute intervals via a setting, Stating that "values below 90 are not recommended and will impact 12v battery performance. USE AT OWN RISK"

@cdnninja
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GameGrime it would restrict the GUI from going below. I am sure you could either edit the raw value or create an automation that calls the force command more often. Also easy to undo this in the code yourself in your custom_components folder for whatever version you are using.

Please sign in to comment.