fix: battery zero incorrect #144
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,18 +53,32 @@ def __init__( | |
|
|
||
| async def update(self): | ||
| try: | ||
| previous_vehicle_status = self.get_child_value("vehicleStatus") | ||
| self.vehicle_data = await self.hass.async_add_executor_job( | ||
| self.kia_uvo_api.get_cached_vehicle_status, self.token | ||
| ) | ||
| self.set_last_updated() | ||
| self.set_engine_type() | ||
| if self.enable_geolocation_entity: | ||
| current_vehicle_location = self.get_child_value("vehicleLocation") | ||
| await self.hass.async_add_executor_job( | ||
| self.set_geocoded_location, current_vehicle_location | ||
| ) | ||
|
|
||
| if ( | ||
| self.get_child_value("vehicleStatus.engine") == False | ||
| and previous_vehicle_status is not None | ||
| and previous_vehicle_status["engine"] == False | ||
| and self.get_child_value("vehicleStatus.evStatus.batteryStatus") == 0 | ||
| and previous_vehicle_status["evStatus"]["batteryStatus"] != 0 | ||
| ): | ||
| _LOGGER.debug( | ||
| f"zero battery api error, force_update started to correct data" | ||
| ) | ||
| await self.force_update() | ||
|
There was a problem hiding this comment. Let's fire this as a separate request rather than waiting results There was a problem hiding this comment. @fuatakgun I can switch this ti a second request, but the reason I did it with waiting is so that scripts in HA that call the update function are able to tell when it actually finishes. If this is changed to async the scripts will call update thinking the values are updated but they won't be until the force update call finishes. |
||
| else: | ||
| async_dispatcher_send(self.hass, self.topic_update) | ||
|
|
||
| except Exception as ex: | ||
| _LOGGER.error( | ||
| f"{DOMAIN} - Exception in update : %s - traceback: %s", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we follow same naming below (current_vehicle_location). I am a bit obsessed with naming :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, let's update below (current into previous)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuatakgun I moved the definition of the currentLocation below the impl update call, I think it isn't so much a naming consistency issue as a bug. I couldn't think of a reason to update the location using the previous location during an update instead of the current.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no reason to call external endpoint if location coordinates have not changed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment is about naming; if we call current location as current, i was saying we should call current vehicle data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ic, it didn't make sense. until I saw the parameter name is old_vehicle_location, previous_vehicle_location seems more inline with old_vehicle_location then current, and make more sense without having to understand it's use.