fix: reduce force refreshing when not needed #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fuatakgun given the restrictions you mentioned for force refreshes I'd like to get this merged soon so the USA users can stop hitting that endpoint a bunch of unneeded times, I've tested every action using this updated code and the results are always up to date since the USA impl waits until the actions are verified completed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #151 this works for the USA kia to avoid calling and waiting to finish the force refresh endpoint since the action is known to have completed and the api has already cached that result. @cdnninja this will probably also work for the CA version but I didn't want to change the impl flag since I can't test it.