Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reusable workflows for tileset composers #2106

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

casswedson
Copy link
Contributor

Summary

reduce the amount of code needed to set up new tilesets

this also makes it easier to maintain all the workflows, they now share a file where all the logic and commands are stored

Content of the change

now setting up a tileset testing workflow looks like this:

  • where we set the most important parts, like the event triggers and path filtering

after that we call a workflow template, similar to a github action with inputs etc. the file has all the code needed to compile a tileset for testing and pushing the result artifact

name: GiantDays composer

on:
  push:
    branches:
      - master
    paths:
      - 'gfx/GiantDays/**'
      - '.github/workflows/giantdays_ci_build.yml'
  pull_request:
    branches:
      - master
    paths:
      - 'gfx/GiantDays/**'
      - '.github/workflows/giantdays_ci_build.yml'

jobs:
  build:
    uses: ./.github/workflows/composer_template.yml
    with:
      tileset: GiantDays
      composer-args: --use-all

Testing

Additional information

reduce the amount of code needed to set up new tilesets

this also makes it easier to maintain all the workflows, they now share
a file where all the logic and commands are stored
@Fris0uman Fris0uman merged commit 6efa3d2 into I-am-Erk:master Aug 14, 2023
15 checks passed
@casswedson casswedson deleted the compress-composers branch August 14, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants