Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ultica] Stooking spot (full,empty) #2215

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Conversation

BjoHart
Copy link
Contributor

@BjoHart BjoHart commented Nov 27, 2023

Summary

Icons for stooking spot (full/empty)

Content of the change

Pull request contains two icons for stooking spots (full/empty)

Testing

stooking

Additional information

None

@BjoHart BjoHart changed the title [Ultica]Stooking spot (full,empty) [Ultica] Stooking spot (full,empty) Nov 27, 2023
@I-am-Erk
Copy link
Owner

I-am-Erk commented Nov 28, 2023

I'm not quite sure what the "full" sprite is, and it looks a little high colour for our project. Something simpler might be good

Edit: ah, I see. I think it's not so much the detail as the colours, it's pretty hard to identify. Did this start life as a photo?

@BjoHart
Copy link
Contributor Author

BjoHart commented Nov 28, 2023

Yes, i started with a photo, this one.
02

These things are relatively bright in real life.
covoni

But i think the height is ok. Should be a litte more then a normal man size.
I tried not to show so many details and to keep the color palette as small as in the guide lines.

What are your thoughts about it?

@BjoHart
Copy link
Contributor Author

BjoHart commented Nov 28, 2023

I changed the full stook. Think it bleends in better.

New

@BjoHart
Copy link
Contributor Author

BjoHart commented Dec 1, 2023

@Fris0uman
Are my changes ok?
I did some work on other pull requests these days...

@I-am-Erk I-am-Erk merged commit 4e1c8a8 into I-am-Erk:master Dec 3, 2023
3 checks passed
@I-am-Erk
Copy link
Owner

I-am-Erk commented Dec 3, 2023

Thanks!

@BjoHart BjoHart deleted the stook branch December 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants