Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF Mappings Based off of 2.0.x #158

Closed
wants to merge 7 commits into from
Closed

Conversation

adamsachs
Copy link
Contributor

[Ignore the silly branch name!]

Updated https://github.com/ethyca/fideslang/pull/153 to be rebased against main (which is 2.0.x).

We can keep both of these branches/PRs open for now; since fides still isn't using fideslang:2.0.x, it can be useful to have these both running open for now. conflicts should be minimal.

If/when we're ready to get these changes into fideslang, we'll hopefully be ready to use fideslang:2.0.x with fides. if so, then we can use this branch/PR (or something similar) to merge these fideslsang updates. if not, then we'll need to use something similar to https://github.com/ethyca/fideslang/pull/153

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps taken to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@pattisdr
Copy link
Contributor

pattisdr commented Sep 13, 2023

Ah I forgot this PR was open, and opened a new one instead of rebasing: https://github.com/ethyca/fideslang/pull/167. I'll close this one. Not deleting branch yet though.

@pattisdr pattisdr closed this Sep 13, 2023
@NevilleS NevilleS deleted the 2.x_temp_gvl_1_4_4_changes branch January 8, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants