-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rachel purpose 11 #171
Rachel purpose 11 #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for me
…e "personalize.profiling" and instead add what it was replaced by.
@ThomasLaPiana I was tagged on review here, I added some unique name cleanup here and then attempted to use your new pattern for deprecating an old use when adding a new one. Is this in line with what you had in mind? Also, do you have existing scripts for building the files in the various formats? EDIT: Found your scripts! We are just removing the data use here instead of deprecating- discussed internally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @pattisdr ! just one small thing that i'm not sure is a problem or me just reading the diff wrong...
going to tentatively approve so that you're not blocked on my approval, trust you can resolve/adjust as needed 👍
Partially closes ethyca/fides#4226
❗ Assumes this goes out with 2.1.1. If not, that needs to be updated in this PR.
Description Of Changes
Will need help with a migration script. Updating Adam's ingestion script.