Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rachel purpose 11 #171

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Rachel purpose 11 #171

merged 10 commits into from
Oct 5, 2023

Conversation

rsilvery
Copy link
Contributor

@rsilvery rsilvery commented Oct 2, 2023

Partially closes ethyca/fides#4226
❗ Assumes this goes out with 2.1.1. If not, that needs to be updated in this PR.

Description Of Changes

  • Updated data uses to assist with GVL mapping as such:
    • Personalize.profiling -> personalize.content.profiling
    • Add personalize.content.profiled
    • Add personalize.content.limited
  • Updated GVL mappings as such:
    • p5: personalize.profiling -> personalize.content.profiling
    • p6: personalize.content -> personalize.content.profiled
    • p11: personalize.system (placeholder) -> personalize.content.limited

Will need help with a migration script. Updating Adam's ingestion script.

data_files/data_uses.csv Outdated Show resolved Hide resolved
src/fideslang/gvl/gvl_data_use_mapping.json Show resolved Hide resolved
@rsilvery rsilvery requested a review from pattisdr October 2, 2023 18:43
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for me

data_files/data_uses.csv Outdated Show resolved Hide resolved
data_files/data_uses.csv Outdated Show resolved Hide resolved
@pattisdr
Copy link
Contributor

pattisdr commented Oct 3, 2023

@ThomasLaPiana I was tagged on review here, I added some unique name cleanup here and then attempted to use your new pattern for deprecating an old use when adding a new one. Is this in line with what you had in mind?

Also, do you have existing scripts for building the files in the various formats?

EDIT: Found your scripts! We are just removing the data use here instead of deprecating- discussed internally.

@rsilvery rsilvery requested a review from a team October 5, 2023 18:44
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @pattisdr ! just one small thing that i'm not sure is a problem or me just reading the diff wrong...

going to tentatively approve so that you're not blocked on my approval, trust you can resolve/adjust as needed 👍

data_files/data_uses.yml Show resolved Hide resolved
@pattisdr pattisdr merged commit 94f9174 into main Oct 5, 2023
31 checks passed
@pattisdr pattisdr deleted the rachel-purpose-11 branch October 5, 2023 20:59
@pattisdr pattisdr mentioned this pull request Oct 6, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate Purpose 11
4 participants