add new tcf fields to system model #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsachs
commented
Oct 5, 2023
| @@ -1138,10 +1138,10 @@ class System(FidesModel): | |||
| description="Deprecated. The responsibility or role over the system that processes personal data", | |||
| ) | |||
| egress: Optional[List[DataFlow]] = Field( | |||
| description="The resources to which the System sends data." | |||
| description="The resources to which the system sends data." | |||
There was a problem hiding this comment.
decided to standardize capitalization of system across the descriptions in this model class while i was here
adamsachs
commented
Oct 5, 2023
| @@ -1225,6 +1225,24 @@ class System(FidesModel): | |||
| data_security_practices: Optional[str] = Field( | |||
| description="The data security practices employed by this system." | |||
| ) | |||
| cookie_max_age_seconds: Optional[int] = Field( | |||
| description="The maximum storage duration, in seconds, for cookies used by this system." | |||
There was a problem hiding this comment.
Descriptions were informed by official spec's descriptions here
adamsachs
force-pushed
the
asachs/172-addtl-tcf-fields
branch
from
40ec6ec
to
8e16f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172
Description Of Changes
See issue description
Code Changes
SystemmodelSteps to Confirm
n/a, automated test coverage should be good enough for us here as this is a pretty straightforward additive change
Pre-Merge Checklist
CHANGELOG.md